Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make logging_component selectable #64

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

robertchoi80
Copy link
Contributor

efk 와 loki 중 선택하여 배포할 수 있도록 lma workflow를 수정하였습니다.
https://github.com/openinfradev/tks-issues/issues/42

현재 파이프라인이 일단 우리가 가진 모든 차트를 decapod-manifests로 렌더링해놓고, 그중에 뭘 배포할지 workflow에서 최종 선택하는 방식이라 kustomize를 활용한 layering이 아니라 본 방식으로 구현하게 되었습니다.

@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Dec 19, 2021
@ktkfree
Copy link
Contributor

ktkfree commented Dec 21, 2021

inferface 변경의 건인데, tks-lma-federation workflow와 tks-cluster-lcm 변경은 필요 없을까요?
변경이 필요하다면 말씀해주세요~

@github-actions github-actions bot removed the Stale There has been no activity on this label Dec 21, 2021
@zugwan
Copy link
Contributor

zugwan commented Dec 21, 2021

@robertchoi80 create-app 반영된 것과 충돌이 발생하네요. 수정 부탁 드려요.

@robertchoi80
Copy link
Contributor Author

inferface 변경의 건인데, tks-lma-federation workflow와 tks-cluster-lcm 변경은 필요 없을까요? 변경이 필요하다면 말씀해주세요~

아, tks-lma-federation 쪽에서는 'logging_component'라는 workflow param을 추가해야 할 것 같고, lcm에서 직접 수정할 부분은 없을 것 같습니다. tks-flow 쪽에 내용 반영할게요

@robertchoi80
Copy link
Contributor Author

robertchoi80 commented Dec 21, 2021

@robertchoi80 create-app 반영된 것과 충돌이 발생하네요. 수정 부탁 드려요.

네 지금 수정 중입니다
-> rebase가 완벽히 안되어 누락된 내용들 손으로 다시 추가했습니다. 이제 main에 머지할게요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants