remove-lma-uniformed: fix wrong template name #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
reviewed
Jan 27, 2022
| @@ -8,20 +8,17 @@ spec: | |||
| entrypoint: process | |||
| arguments: | |||
| parameters: | |||
| - name: project | |||
| value: "lma" | |||
| # Filter to filter argocd apps (E.g., "app=lma") | |||
| - name: filter | |||
| value: "" | |||
There was a problem hiding this comment.
기본 값이 비어있기 때문에 이름과는 다르게 filter 변수를 어떻게 입력하느냐에 따라 ArgoCD App을 삭제하는 범용적인 워크플로우 템플릿으로 보이기도 하네요. 주석 내용과 같이 기본 값은 "app=lma"으로 하는 것이 좋을 거 같습니다.
There was a problem hiding this comment.
그렇네요. 범용 workflow 는 delete-apps 쪽에 entrypoint 만 추가해서 만들 수도 있으니, 이건 lma 전용으로 써야겠네요. 수정했습니다!
zugwan
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
싱크 안 맞는 template name 수정