Allow users to set duration instead of end date #32 #47
Conversation
|
In general, please provide a description what this PR includes and what it doesn't |
|
@leonardohof I think we need an extra property for This issue is mainly to deal with incoming events that have duration or endtime defined. |
|
Can you please attach a quick screenshot of the UI? |
|
@friedger Ok. |
|
Looks good, we have to find a better UX, but that is another issue. |
|
@friedger I tried to import my google calendar, but none of my events appeared. And, i didn't see in Google Calendar the option to set a duration instead end date. |
|
I'm using "cors everywhere" on Firefox.
Google calendar does not provide this feature but 5he specification allows
to use one or the other.
…On Fri, 8 Feb 2019, 19:15 Leonardo Hofling, ***@***.***> wrote:
@friedger <https://github.com/friedger> I tried to import my google
calendar, but none of my events appeared. And, i didn't see in Google
Calendar the option to set a duration instead end date.
And, one last item: what CORS plugin are you using on Chrome/Firefox?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYcWW-s6xeIAkwat4AR8uaiAeKVUGu8ks5vLb6pgaJpZM4ar3jX>
.
|
|
I found this documentation about the field duration and its format is
different that I did.
https://www.kanzaki.com/docs/ical/duration-t.html
And you can specify days or weeks instead time.
What will be the input for the user?
…On Fri, Feb 8, 2019, 18:45 Friedger Müffke ***@***.***> wrote:
I'm using "cors everywhere" on Firefox.
Google calendar does not provide this feature but 5he specification allows
to use one or the other.
On Fri, 8 Feb 2019, 19:15 Leonardo Hofling, ***@***.***>
wrote:
> @friedger <https://github.com/friedger> I tried to import my google
> calendar, but none of my events appeared. And, i didn't see in Google
> Calendar the option to set a duration instead end date.
> And, one last item: what CORS plugin are you using on Chrome/Firefox?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#47 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABYcWW-s6xeIAkwat4AR8uaiAeKVUGu8ks5vLb6pgaJpZM4ar3jX
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAR-BlzLJtlBoHQfvpsV0Wg2s8rBqTmxks5vLeHagaJpZM4ar3jX>
.
|
|
we are using https://www.npmjs.com/package/ics to create this field, so we only need to worry that this library gets the correct value. Limiting the duration to hours is fine for now. |
|
Ok
…On Fri, Feb 8, 2019, 19:37 Friedger Müffke ***@***.***> wrote:
we are using https://www.npmjs.com/package/ics to create this field, so
we only need to worry that this library gets the correct value. Limiting
the duration to hours is fine for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAR-BvwnkEPd-3EelIZE193zpRkJPrr9ks5vLe42gaJpZM4ar3jX>
.
|
|
@friedger I did some changes in ical.js, to include the duration field in the import/export feature of ics files, following the ics documentation that you sent. |
|
@leonardohof that looks good, I have two smaller comments. Any ideas about adding a test? |
|
|
@leonardohof I just pushed a fix for the App test in the develop branch. How would you write a test for the ical import/export? |
|
@leonardohof I haven't thought of the all day case. What could be a good behavior if the checkbox "all day" is checked on and off? |
|
@leonardohof I am on matrix now. |
Done. |
|
Thank you for the work |
No description provided.