Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Commit

Permalink
Merge pull request #6 from openizr/0.0.13
Browse files Browse the repository at this point in the history 
Set Textfield and Textarea fields types' debounceTimeout option to 10…
  • Loading branch information
@matthieujabbour
matthieujabbour committed Jun 20, 2021
2 parents ae69f24 + 85d6cd2 commit 5d1e47a
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 17 deletions.
2 changes: 1 addition & 1 deletion library/src/scripts/plugins/valuesLoader.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default function valuesLoader(options: Options): Plugin {
// Loads default values defined in configuration's fields, as well as values already filled.
engine.on('loadedNextStep', (nextStep, next) => {
// Retrieving stored values from cache...
const cachePromise = (loadedCache === false)
const cachePromise = (loadedCache === false && enabled === true)
? localforage.getItem(cacheKey)
: Promise.resolve(null);

Expand Down
4 changes: 2 additions & 2 deletions library/src/scripts/react/components/Field.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const builtInComponents: Components = {
autocomplete={field.options.autocomplete}
iconPosition={field.options.iconPosition}
helper={field.message || field.options.helper}
debounceTimeout={field.options.debounceTimeout}
debounceTimeout={field.options.debounceTimeout || 100}
readonly={field.options.readonly || field.active === false}
modifiers={`${field.status} ${field.options.modifiers || ''}`}
/>
Expand All @@ -97,7 +97,7 @@ const builtInComponents: Components = {
placeholder={field.options.placeholder}
autocomplete={field.options.autocomplete}
helper={field.message || field.options.helper}
debounceTimeout={field.options.debounceTimeout}
debounceTimeout={field.options.debounceTimeout || 100}
readonly={field.options.readonly || field.active === false}
modifiers={`${field.status} ${field.options.modifiers || ''}`}
/>
Expand Down
1 change: 1 addition & 0 deletions library/src/scripts/react/components/__tests__/Field.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jest.mock('sonar-ui/react', () => {
onClick={props.onClick}
onKeyDown={props.onFocus}
data-readonly={props.readonly}
data-debounce-timeout={props.debounceTimeout}
/>
);
}
Expand Down
10 changes: 10 additions & 0 deletions library/src/scripts/react/components/__tests__/__snapshots__/Field.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ exports[`react/components/Field Radio 1`] = `
exports[`react/components/Field Textarea - active step 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textarea"
/>
Expand All @@ -72,6 +73,7 @@ exports[`react/components/Field Textarea - active step 1`] = `
exports[`react/components/Field Textarea - active step, readonly option is \`true\` 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="true"
id="Textarea"
/>
Expand All @@ -81,6 +83,7 @@ exports[`react/components/Field Textarea - active step, readonly option is \`tru
exports[`react/components/Field Textarea - with no onFocus method 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textarea"
/>
Expand All @@ -90,6 +93,7 @@ exports[`react/components/Field Textarea - with no onFocus method 1`] = `
exports[`react/components/Field Textarea - with onFocus method, inactive step 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="true"
id="Textarea"
/>
Expand All @@ -99,6 +103,7 @@ exports[`react/components/Field Textarea - with onFocus method, inactive step 1`
exports[`react/components/Field Textarea - with onFocus method, inactive step 2`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textarea"
/>
Expand All @@ -108,6 +113,7 @@ exports[`react/components/Field Textarea - with onFocus method, inactive step 2`
exports[`react/components/Field Textfield - active step 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textfield"
/>
Expand All @@ -117,6 +123,7 @@ exports[`react/components/Field Textfield - active step 1`] = `
exports[`react/components/Field Textfield - active step, readonly option is \`true\` 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="true"
id="Textfield"
/>
Expand All @@ -126,6 +133,7 @@ exports[`react/components/Field Textfield - active step, readonly option is \`tr
exports[`react/components/Field Textfield - with no onFocus method 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textfield"
/>
Expand All @@ -135,6 +143,7 @@ exports[`react/components/Field Textfield - with no onFocus method 1`] = `
exports[`react/components/Field Textfield - with onFocus method, inactive step 1`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="true"
id="Textfield"
/>
Expand All @@ -144,6 +153,7 @@ exports[`react/components/Field Textfield - with onFocus method, inactive step 1
exports[`react/components/Field Textfield - with onFocus method, inactive step 2`] = `
<div>
<div
data-debounce-timeout="100"
data-readonly="false"
id="Textfield"
/>
Expand Down
4 changes: 2 additions & 2 deletions library/src/scripts/vue/components/Field.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ const builtInComponents: Components = {
placeholder: field.options.placeholder,
iconPosition: field.options.iconPosition,
helper: field.message || field.options.helper,
debounceTimeout: field.options.debounceTimeout,
debounceTimeout: field.options.debounceTimeout || 100,
modifiers: `${field.status} ${field.options.modifiers || ''} `,
},
events: {
Expand All @@ -180,7 +180,7 @@ const builtInComponents: Components = {
placeholder: field.options.placeholder,
autocomplete: field.options.autocomplete,
helper: field.message || field.options.helper,
debounceTimeout: field.options.debounceTimeout,
debounceTimeout: field.options.debounceTimeout || 100,
readonly: field.options.readonly || field.active === false,
modifiers: `${field.status} ${field.options.modifiers || ''}`,
},
Expand Down
24 changes: 12 additions & 12 deletions library/src/scripts/vue/components/__tests__/__snapshots__/Field.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@ exports[`vue/components/Field Message with label 1`] = `"<section id=\\"Message\
exports[`vue/components/Field Radio 1`] = `"<div id=\\"Radio\\" name=\\"Radio\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - active step, readonly option is \`true\` 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - active step, readonly option is \`true\` 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - active then inactive step 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - active then inactive step 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - active then inactive step 2`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" modifiers=\\"initial \\" readonly=\\"readonly\\"></div>"`;
exports[`vue/components/Field Textarea - active then inactive step 2`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\" readonly=\\"readonly\\"></div>"`;
exports[`vue/components/Field Textarea - with no onFocus method 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - with no onFocus method 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - with onFocus method, inactive step 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - with onFocus method, inactive step 1`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - with onFocus method, inactive step 2`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textarea - with onFocus method, inactive step 2`] = `"<div id=\\"Textarea\\" name=\\"Textarea\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - active step, readonly option is \`true\` 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - active step, readonly option is \`true\` 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" readonly=\\"readonly\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - active then inactive step 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - active then inactive step 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - active then inactive step 2`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" modifiers=\\"initial \\" readonly=\\"readonly\\"></div>"`;
exports[`vue/components/Field Textfield - active then inactive step 2`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\" readonly=\\"readonly\\"></div>"`;
exports[`vue/components/Field Textfield - with no onFocus method 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - with no onFocus method 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - with onFocus method, inactive step 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" readonly=\\"readonly\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - with onFocus method, inactive step 1`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" readonly=\\"readonly\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - with onFocus method, inactive step 2`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field Textfield - with onFocus method, inactive step 2`] = `"<div id=\\"Textfield\\" name=\\"Textfield\\" label=\\"Test\\" debouncetimeout=\\"100\\" modifiers=\\"initial \\"></div>"`;
exports[`vue/components/Field unknown field type 1`] = `""`;

0 comments on commit 5d1e47a

Please sign in to comment.