Skip to content

Commit

Permalink
8269258: java/net/httpclient/ManyRequestsLegacy.java failed with conn…
Browse files Browse the repository at this point in the history 
…ection timeout

Reviewed-by: michaelm
  • Loading branch information
@dfuch
dfuch committed Dec 8, 2021
1 parent fd8cb2d commit 37921e3
Show file tree
Hide file tree
Showing 3 changed files with 274 additions and 126 deletions.
204 changes: 140 additions & 64 deletions test/jdk/java/net/httpclient/ManyRequests.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -32,13 +32,13 @@
* @compile ../../../com/sun/net/httpserver/LogFilter.java
* @compile ../../../com/sun/net/httpserver/EchoHandler.java
* @compile ../../../com/sun/net/httpserver/FileServerHandler.java
* @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=ssl ManyRequests
* @run main/othervm/timeout=40 -Dtest.insertDelay=true ManyRequests
* @run main/othervm/timeout=40 -Dtest.chunkSize=64 ManyRequests
* @run main/othervm/timeout=40 -Dtest.insertDelay=true -Dtest.chunkSize=64 ManyRequests
* @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=ssl,channel ManyRequests
* @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=channel -Dtest.insertDelay=true ManyRequests
* @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=channel -Dtest.chunkSize=64 ManyRequests
* @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=channel -Dtest.insertDelay=true -Dtest.chunkSize=64 ManyRequests
* @summary Send a large number of requests asynchronously
*/
// * @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=ssl ManyRequests
// * @run main/othervm/timeout=40 -Djdk.httpclient.HttpClient.log=ssl,channel ManyRequests

import com.sun.net.httpserver.HttpsConfigurator;
import com.sun.net.httpserver.HttpsParameters;
Expand All @@ -47,38 +47,54 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.net.ConnectException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.URI;
import java.net.http.HttpClient;
import java.net.http.HttpClient.Builder;
import java.net.http.HttpRequest;
import java.net.http.HttpRequest.BodyPublishers;
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import java.time.Duration;
import java.util.Arrays;
import java.util.Formatter;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.Map;
import java.util.Random;
import java.util.concurrent.CompletionException;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.logging.Logger;
import java.util.logging.Level;
import java.util.concurrent.CompletableFuture;
import java.util.stream.Stream;
import javax.net.ssl.SSLContext;

import jdk.test.lib.Platform;
import jdk.test.lib.RandomFactory;
import jdk.test.lib.net.SimpleSSLContext;
import jdk.test.lib.net.URIBuilder;

public class ManyRequests {

volatile static int counter = 0;
static final int MAX_COUNT = 20;
static final int MAX_LIMIT = 40;
static final AtomicInteger COUNT = new AtomicInteger();
static final AtomicInteger LIMIT = new AtomicInteger(MAX_LIMIT);
static final Random RANDOM = RandomFactory.getRandom();

public static void main(String[] args) throws Exception {
Logger logger = Logger.getLogger("com.sun.net.httpserver");
logger.setLevel(Level.ALL);
logger.info("TEST");
Stream.of(Logger.getLogger("").getHandlers()).forEach((h) -> h.setLevel(Level.ALL));
System.out.println("Sending " + REQUESTS
+ " requests; delay=" + INSERT_DELAY
+ ", chunks=" + CHUNK_SIZE
Expand Down Expand Up @@ -106,14 +122,14 @@ public static void main(String[] args) throws Exception {
}

//static final int REQUESTS = 1000;
static final int REQUESTS = 20;
static final int REQUESTS = MAX_COUNT;
static final boolean INSERT_DELAY = Boolean.getBoolean("test.insertDelay");
static final int CHUNK_SIZE = Math.max(0,
Integer.parseInt(System.getProperty("test.chunkSize", "0")));
static final boolean XFIXED = Boolean.getBoolean("test.XFixed");

static class TestEchoHandler extends EchoHandler {
final Random rand = jdk.test.lib.RandomFactory.getRandom();
final Random rand = RANDOM;
@Override
public void handle(HttpExchange e) throws IOException {
System.out.println("Server: received " + e.getRequestURI());
Expand All @@ -139,60 +155,126 @@ protected void close(HttpExchange t, InputStream is) throws IOException {
}
}

static String now(long start) {
long elapsed = System.nanoTime() - start;
long ms = elapsed / 1000_000L;
long s = ms / 1000L;
if (s == 0) return ms + "ms: ";
return s + "s, " + (ms - s * 1000L) + "ms: ";
}

static String failure(Throwable t) {
String s = "\n\t failed: " + t;
for (t = t.getCause(); t != null ; t = t.getCause()) {
s = s + "\n\t\t Caused by: " + t;
}
return s;
}

static void test(HttpsServer server, HttpClient client) throws Exception {
int port = server.getAddress().getPort();
URI baseURI = new URI("https://localhost:" + port + "/foo/x");

URI baseURI = URIBuilder.newBuilder()
.scheme("https")
.host(InetAddress.getLoopbackAddress().getHostName())
.port(port)
.path("/foo/x").build();
server.createContext("/foo", new TestEchoHandler());
server.start();

RequestLimiter limiter = new RequestLimiter(40);
Random rand = new Random();
CompletableFuture<?>[] results = new CompletableFuture<?>[REQUESTS];
HashMap<HttpRequest,byte[]> bodies = new HashMap<>();

for (int i=0; i<REQUESTS; i++) {
byte[] buf = new byte[(i+1)*CHUNK_SIZE+i+1]; // different size bodies
rand.nextBytes(buf);
URI uri = new URI(baseURI.toString() + String.valueOf(i+1));
HttpRequest r = HttpRequest.newBuilder(uri)
.header("XFixed", "true")
.POST(BodyPublishers.ofByteArray(buf))
.build();
bodies.put(r, buf);

results[i] =
limiter.whenOkToSend()
.thenCompose((v) -> {
System.out.println("Client: sendAsync: " + r.uri());
return client.sendAsync(r, BodyHandlers.ofByteArray());
})
.thenCompose((resp) -> {
limiter.requestComplete();
if (resp.statusCode() != 200) {
String s = "Expected 200, got: " + resp.statusCode();
System.out.println(s + " from "
+ resp.request().uri().getPath());
return completedWithIOException(s);
} else {
counter++;
System.out.println("Result (" + counter + ") from "
+ resp.request().uri().getPath());
}
return CompletableFuture.completedStage(resp.body())
.thenApply((b) -> new Pair<>(resp, b));
})
.thenAccept((pair) -> {
HttpRequest request = pair.t.request();
byte[] requestBody = bodies.get(request);
check(Arrays.equals(requestBody, pair.u),
"bodies not equal:[" + bytesToHexString(requestBody)
+ "] [" + bytesToHexString(pair.u) + "]");

});
}
// This loop implements a retry mechanism to work around an issue
// on some systems (observed on Windows 10) that seem to be trying to
// throttle the number of connections that can be made concurrently by
// rejecting connection attempts.
// On the first iteration of this loop, we will attempt 20 concurrent
// requests. If this fails with ConnectException, we will retry the
// 20 requests, but limiting the concurrency to 10 (LIMIT <- 10).
// If this fails again, the test will fail.
boolean done = false;
LOOP: do {
RequestLimiter limiter = new RequestLimiter(LIMIT.get());
Random rand = RANDOM;
CompletableFuture<?>[] results = new CompletableFuture<?>[REQUESTS];
Map<HttpRequest,byte[]> bodies = new ConcurrentHashMap<>();

long start = System.nanoTime();

for (int i = 0; i < REQUESTS; i++) {
byte[] buf = new byte[(i + 1) * CHUNK_SIZE + i + 1]; // different size bodies
rand.nextBytes(buf);
URI uri = new URI(baseURI.toString() + String.valueOf(i + 1));
HttpRequest r = HttpRequest.newBuilder(uri)
.header("XFixed", "true")
.POST(BodyPublishers.ofByteArray(buf))
.build();
bodies.put(r, buf);

results[i] =
limiter.whenOkToSend()
.thenCompose((v) -> {
System.out.println("Client: sendAsync: " + r.uri());
return client.sendAsync(r, BodyHandlers.ofByteArray());
})
.handle((resp, t) -> {
limiter.requestComplete();
CompletionStage<Pair<HttpResponse<byte[]>, byte[]>> res;
String now = now(start);
if (t == null) {
if (resp.statusCode() != 200) {
String s = "Expected 200, got: " + resp.statusCode();
System.out.println(now + s + " from "
+ resp.request().uri().getPath());
res = completedWithIOException(s);
return res;
} else {
int counter = COUNT.incrementAndGet();
System.out.println(now + "Result (" + counter + ") from "
+ resp.request().uri().getPath());
}
res = CompletableFuture.completedStage(resp.body())
.thenApply((b) -> new Pair<>(resp, b));
return res;
} else {
int counter = COUNT.incrementAndGet();
System.out.println(now + "Result (" + counter + ") from "
+ r.uri().getPath()
+ failure(t));
res = CompletableFuture.failedFuture(t);
return res;
}
})
.thenCompose(c -> c)
.thenAccept((pair) -> {
HttpRequest request = pair.t.request();
byte[] requestBody = bodies.get(request);
check(Arrays.equals(requestBody, pair.u),
"bodies not equal:[" + bytesToHexString(requestBody)
+ "] [" + bytesToHexString(pair.u) + "]");

});
}

// wait for them all to complete and throw exception in case of err
try {
CompletableFuture.allOf(results).join();
done = true;
} catch (CompletionException e) {
if (!Platform.isWindows()) throw e;
if (LIMIT.get() < REQUESTS) throw e;
Throwable cause = e;
while ((cause = cause.getCause()) != null) {
if (cause instanceof ConnectException) {
// try again, limit concurrency by half
COUNT.set(0);
LIMIT.set(REQUESTS/2);
System.out.println("*** Retrying due to " + cause);
continue LOOP;
}
}
throw e;
}
} while (!done);

// wait for them all to complete and throw exception in case of error
CompletableFuture.allOf(results).join();
}

static <T> CompletableFuture<T> completedWithIOException(String message) {
Expand All @@ -213,13 +295,7 @@ static String bytesToHexString(byte[] bytes) {
return sb.toString();
}

static final class Pair<T,U> {
Pair(T t, U u) {
this.t = t; this.u = u;
}
T t;
U u;
}
record Pair<T,U>(T t, U u) { }

/**
* A simple limiter for controlling the number of requests to be run in
Expand Down
12 changes: 8 additions & 4 deletions test/jdk/java/net/httpclient/ManyRequests2.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -33,10 +33,14 @@
* @compile ../../../com/sun/net/httpserver/EchoHandler.java
* @compile ../../../com/sun/net/httpserver/FileServerHandler.java
* @build ManyRequests ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true -Dtest.insertDelay=true ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true -Dtest.chunkSize=64 ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true
* -Djdk.httpclient.HttpClient.log=channel ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true -Dtest.insertDelay=true
* -Djdk.httpclient.HttpClient.log=channel ManyRequests2
* @run main/othervm/timeout=40 -Dtest.XFixed=true -Dtest.chunkSize=64
* -Djdk.httpclient.HttpClient.log=channel ManyRequests2
* @run main/othervm/timeout=40 -Djdk.internal.httpclient.debug=true
* -Djdk.httpclient.HttpClient.log=channel
* -Dtest.XFixed=true -Dtest.insertDelay=true
* -Dtest.chunkSize=64 ManyRequests2
* @summary Send a large number of requests asynchronously.
Expand Down
Loading

3 comments on commit 37921e3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 37921e3 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 37921e3 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-37921e30 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 37921e30 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Fuchs on 8 Dec 2021 and was reviewed by Michael McMahon.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-37921e30:GoeLin-backport-37921e30
$ git checkout GoeLin-backport-37921e30
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-37921e30

Please sign in to comment.