-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8268339: Upstream: 8267989: Exceptions thrown during upcalls should b…
…e handled Reviewed-by: psandoz, mcimadamore
- Loading branch information
1 parent
1fd8146
commit ab01cb5
Showing
8 changed files
with
229 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @requires ((os.arch == "amd64" | os.arch == "x86_64") & sun.arch.data.model == "64") | os.arch == "aarch64" | ||
* @library /test/lib | ||
* @modules jdk.incubator.foreign/jdk.internal.foreign | ||
* @build ThrowingUpcall TestUpcallException | ||
* | ||
* @run testng/othervm/native | ||
* --enable-native-access=ALL-UNNAMED | ||
* TestUpcallException | ||
*/ | ||
|
||
import jdk.incubator.foreign.CLinker; | ||
import jdk.incubator.foreign.FunctionDescriptor; | ||
import jdk.incubator.foreign.ResourceScope; | ||
import jdk.test.lib.Utils; | ||
import org.testng.annotations.Test; | ||
|
||
import java.io.BufferedReader; | ||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.io.InputStreamReader; | ||
import java.nio.file.Paths; | ||
import java.util.List; | ||
|
||
import static org.testng.Assert.assertFalse; | ||
import static org.testng.Assert.assertNotEquals; | ||
import static org.testng.Assert.assertTrue; | ||
|
||
public class TestUpcallException { | ||
|
||
@Test | ||
public void testExceptionInterpreted() throws InterruptedException, IOException { | ||
boolean useSpec = false; | ||
run(useSpec); | ||
} | ||
|
||
@Test | ||
public void testExceptionSpecialized() throws IOException, InterruptedException { | ||
boolean useSpec = true; | ||
run(useSpec); | ||
} | ||
|
||
private void run(boolean useSpec) throws IOException, InterruptedException { | ||
Process process = new ProcessBuilder() | ||
.command( | ||
Paths.get(Utils.TEST_JDK) | ||
.resolve("bin") | ||
.resolve("java") | ||
.toAbsolutePath() | ||
.toString(), | ||
"--add-modules", "jdk.incubator.foreign", | ||
"--enable-native-access=ALL-UNNAMED", | ||
"-Djava.library.path=" + System.getProperty("java.library.path"), | ||
"-Djdk.internal.foreign.ProgrammableUpcallHandler.USE_SPEC=" + useSpec, | ||
"-cp", Utils.TEST_CLASS_PATH, | ||
"ThrowingUpcall") | ||
.start(); | ||
|
||
int result = process.waitFor(); | ||
assertNotEquals(result, 0); | ||
|
||
List<String> outLines = linesFromStream(process.getInputStream()); | ||
outLines.forEach(System.out::println); | ||
List<String> errLines = linesFromStream(process.getErrorStream()); | ||
errLines.forEach(System.err::println); | ||
|
||
// Exception message would be found in stack trace | ||
String shouldInclude = "Testing upcall exceptions"; | ||
assertTrue(linesContain(errLines, shouldInclude), "Did not find '" + shouldInclude + "' in stderr"); | ||
} | ||
|
||
private boolean linesContain(List<String> errLines, String shouldInclude) { | ||
return errLines.stream().anyMatch(line -> line.contains(shouldInclude)); | ||
} | ||
|
||
private static List<String> linesFromStream(InputStream stream) throws IOException { | ||
try (BufferedReader reader = new BufferedReader(new InputStreamReader(stream))) { | ||
return reader.lines().toList(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
import jdk.incubator.foreign.CLinker; | ||
import jdk.incubator.foreign.FunctionDescriptor; | ||
import jdk.incubator.foreign.MemoryAddress; | ||
import jdk.incubator.foreign.ResourceScope; | ||
import jdk.incubator.foreign.SymbolLookup; | ||
|
||
import java.lang.invoke.MethodHandle; | ||
import java.lang.invoke.MethodHandles; | ||
import java.lang.invoke.MethodType; | ||
import java.security.Permission; | ||
|
||
import static jdk.incubator.foreign.CLinker.C_POINTER; | ||
|
||
public class ThrowingUpcall { | ||
|
||
private static final MethodHandle downcall; | ||
public static final MethodHandle MH_throwException; | ||
|
||
static { | ||
System.loadLibrary("TestUpcall"); | ||
SymbolLookup lookup = SymbolLookup.loaderLookup(); | ||
downcall = CLinker.getInstance().downcallHandle( | ||
lookup.lookup("f0_V__").orElseThrow(), | ||
MethodType.methodType(void.class, MemoryAddress.class), | ||
FunctionDescriptor.ofVoid(C_POINTER) | ||
); | ||
|
||
try { | ||
MH_throwException = MethodHandles.lookup().findStatic(ThrowingUpcall.class, "throwException", | ||
MethodType.methodType(void.class)); | ||
} catch (ReflectiveOperationException e) { | ||
throw new ExceptionInInitializerError(e); | ||
} | ||
} | ||
|
||
public static void throwException() throws Throwable { | ||
throw new Throwable("Testing upcall exceptions"); | ||
} | ||
|
||
public static void main(String[] args) throws Throwable { | ||
test(); | ||
} | ||
|
||
public static void test() throws Throwable { | ||
MethodHandle handle = MH_throwException; | ||
MethodHandle invoker = MethodHandles.exactInvoker(MethodType.methodType(void.class)); | ||
handle = MethodHandles.insertArguments(invoker, 0, handle); | ||
|
||
try (ResourceScope scope = ResourceScope.newConfinedScope()) { | ||
MemoryAddress stub = CLinker.getInstance().upcallStub(handle, FunctionDescriptor.ofVoid(), scope); | ||
|
||
downcall.invokeExact(stub); // should call Shutdown.exit(1); | ||
} | ||
} | ||
|
||
} |
ab01cb5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues