Skip to content

Commit

Permalink
6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
Browse files Browse the repository at this point in the history
Reviewed-by: jdv, dnguyen
  • Loading branch information
mrserb committed Nov 24, 2022
1 parent 09ac9eb commit abeddab
Showing 1 changed file with 51 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*
* Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import java.awt.Color;
import java.awt.color.ColorSpace;

/**
* @test
* @bug 6528710
* @summary Verifies sRGB-ColorSpace to sRGB-ColorSpace conversion quality
*/
public final class SimpleSRGBConversionQualityTest {

public static void main(String[] args) {
ColorSpace cspace = ColorSpace.getInstance(ColorSpace.CS_sRGB);
float fvalue[] = {1.0f, 1.0f, 1.0f};

Color c = new Color(cspace, fvalue, 1.0f);
if (c.getRed() != 255 || c.getGreen() != 255 || c.getBlue() != 255) {
throw new RuntimeException("Wrong color: " + c);
}

float frgbvalue[] = cspace.toRGB(fvalue);
for (int i = 0; i < 3; ++i) {
if (frgbvalue[i] != 1.0f) {
System.err.println(fvalue[i] + " -> " + frgbvalue[i]);
throw new RuntimeException("Wrong value");
}
}
}
}

7 comments on commit abeddab

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb
Copy link
Member Author

@mrserb mrserb commented on abeddab Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on abeddab Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-abeddab9 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit abeddab9 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev mrserb-backport-abeddab9:mrserb-backport-abeddab9
$ git checkout mrserb-backport-abeddab9
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev mrserb-backport-abeddab9

@mrserb
Copy link
Member Author

@mrserb mrserb commented on abeddab Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on abeddab Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-abeddab9 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit abeddab9 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-abeddab9:mrserb-backport-abeddab9
$ git checkout mrserb-backport-abeddab9
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-abeddab9

@mrserb
Copy link
Member Author

@mrserb mrserb commented on abeddab Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk8u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on abeddab Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb Could not automatically backport abeddab9 to openjdk/jdk8u-dev due to conflicts in the following files:

  • jdk/test/java/awt/Color/ICC_ColorSpace/SimpleSRGBConversionQualityTest.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk8u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk8u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b mrserb-backport-abeddab9

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git abeddab991d71f4ea54665082ffcb284267d7f44

# Backport the commit
$ git cherry-pick --no-commit abeddab991d71f4ea54665082ffcb284267d7f44
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport abeddab991d71f4ea54665082ffcb284267d7f44'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk8u-dev with the title Backport abeddab991d71f4ea54665082ffcb284267d7f44.

Please sign in to comment.