-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8286669: Replace MethodHandle specialization with ASM in mainline
Co-authored-by: Jorn Vernee <jvernee@openjdk.org> Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org> Reviewed-by: mcimadamore
- Loading branch information
1 parent
d8b0b32
commit ee45a0a
Showing
24 changed files
with
1,482 additions
and
785 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. Oracle designates this | ||
* particular file as subject to the "Classpath" exception as provided | ||
* by Oracle in the LICENSE file that accompanied this code. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
package jdk.internal.foreign.abi; | ||
|
||
import jdk.internal.foreign.SystemLookup; | ||
import jdk.internal.foreign.abi.aarch64.linux.LinuxAArch64Linker; | ||
import jdk.internal.foreign.abi.aarch64.macos.MacOsAArch64Linker; | ||
import jdk.internal.foreign.abi.x64.sysv.SysVx64Linker; | ||
import jdk.internal.foreign.abi.x64.windows.Windowsx64Linker; | ||
|
||
import java.lang.foreign.FunctionDescriptor; | ||
import java.lang.foreign.Linker; | ||
import java.lang.foreign.MemorySegment; | ||
import java.lang.foreign.MemorySession; | ||
import java.lang.invoke.MethodHandle; | ||
import java.lang.invoke.MethodType; | ||
import java.util.Objects; | ||
|
||
public abstract sealed class AbstractLinker implements Linker permits LinuxAArch64Linker, MacOsAArch64Linker, | ||
SysVx64Linker, Windowsx64Linker { | ||
|
||
private final SoftReferenceCache<FunctionDescriptor, MethodHandle> DOWNCALL_CACHE = new SoftReferenceCache<>(); | ||
|
||
@Override | ||
public MethodHandle downcallHandle(FunctionDescriptor function) { | ||
Objects.requireNonNull(function); | ||
|
||
return DOWNCALL_CACHE.get(function, fd -> { | ||
MethodType type = SharedUtils.inferMethodType(fd, false); | ||
MethodHandle handle = arrangeDowncall(type, fd); | ||
handle = SharedUtils.maybeInsertAllocator(handle); | ||
return handle; | ||
}); | ||
} | ||
protected abstract MethodHandle arrangeDowncall(MethodType inferredMethodType, FunctionDescriptor function); | ||
|
||
@Override | ||
public MemorySegment upcallStub(MethodHandle target, FunctionDescriptor function, MemorySession scope) { | ||
Objects.requireNonNull(scope); | ||
Objects.requireNonNull(target); | ||
Objects.requireNonNull(function); | ||
SharedUtils.checkExceptions(target); | ||
|
||
MethodType type = SharedUtils.inferMethodType(function, true); | ||
if (!type.equals(target.type())) { | ||
throw new IllegalArgumentException("Wrong method handle type: " + target.type()); | ||
} | ||
return arrangeUpcall(target, target.type(), function, scope); | ||
} | ||
|
||
protected abstract MemorySegment arrangeUpcall(MethodHandle target, MethodType targetType, | ||
FunctionDescriptor function, MemorySession scope); | ||
|
||
@Override | ||
public SystemLookup defaultLookup() { | ||
return SystemLookup.getInstance(); | ||
} | ||
} |
Oops, something went wrong.
ee45a0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues