8254876: (fs) NullPointerException not thrown when first argument to Path.of or Paths.get is null

[bplb]

Please review this simple fix to have Path.of(String,String) throw a NullPointerException if the first parameter is null.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	⏳ (3/9 running)	⏳ (6/9 running)	⏳ (9/9 running)	⏳ (9/9 running)

Issue

• JDK-8254876: (fs) NullPointerException not thrown when first argument to Path.of or Paths.get is null

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1020/head:pull/1020
$ git checkout pull/1020

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (30a7fc6)
• 02: Full - Incremental (3bcce9a)
• 01: Full - Incremental (5d5adf4)
• 00: Full (7230ae9)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254876: (fs) NullPointerException not thrown when first argument to Path.of or Paths.get is null

Reviewed-by: rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• b46d73b: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
• 6606e09: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false
• 88ee973: 8254827: JVMCI: Enable it for Windows+AArch64
• f64a15d: 8254315: Shenandoah: Concurrent weak reference processing
• 83f3cf4: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
• 134e22a: 8255606: Enable concurrent stack processing on x86_32 platforms
• ca216ba: 8255810: Zero: build fails without JVMTI
• d47336b: 8248320: Provide a unique accessible name for
• 64a9811: 8255798: Remove dead headless code in CompileJavaModules.gmk
• 364b0fe: 8255801: Race when building ct.sym build tools
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/05bcd67e6501f3824020edd1ab036c87888fa229...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

@bplb Since your change was applied there have been 38 commits pushed to the master branch:

• b46d73b: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
• 6606e09: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false
• 88ee973: 8254827: JVMCI: Enable it for Windows+AArch64
• f64a15d: 8254315: Shenandoah: Concurrent weak reference processing
• 83f3cf4: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
• 134e22a: 8255606: Enable concurrent stack processing on x86_32 platforms
• ca216ba: 8255810: Zero: build fails without JVMTI
• d47336b: 8248320: Provide a unique accessible name for
• 64a9811: 8255798: Remove dead headless code in CompileJavaModules.gmk
• 364b0fe: 8255801: Race when building ct.sym build tools
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/05bcd67e6501f3824020edd1ab036c87888fa229...master

Your commit was automatically rebased without conflicts.

Pushed as commit 450452b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[AlanBateman]

I've added release-note=yes to the JBS issue as I think this one will need a release note. There may be an argument to submit a CSR too as this is changing long standing behavior (to align the method with its specification).