-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294488: Delete KCMS transforms wrappers #10459
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
It looks Ok. I ran all our automated tests and there was only one failure - of a closed (for no particular reason) jtreg test |
I've prepared a closed PR which fixes the closed test to match this change |
Thank you! I'll do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed PR is approved. So if you do the /integrate defer trick I'll take care of the rest.
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 408 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate defer |
@mrserb Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command. |
/integrate |
Going to push as commit d8573b2.
Your commit was automatically rebased without conflicts. |
This is a request to cleanup the shared code for the colors conversions. That code still uses some wrappers which can be simplified and/or deleted after KCMS removal. For example, each conversion from one color space to another creates 3 wrappers - for the first color profile, the second color profile, and one to combine the first two. But for the lcms library we only need the list of color profiles and rendering intent -> only one transform object can be used.
The new constructor for the LCMSTransform is added and now used everywhere:
LCMSTransform(int renderingIntent, ICC_Profile... profiles)
It will wrap the
cmsCreateMultiprofileTransform
function in LCMS library:I tried to preserve the current behavior, and as a result, two "workarounds" are used for the next bugs.
Notes:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10459/head:pull/10459
$ git checkout pull/10459
Update a local copy of the PR:
$ git checkout pull/10459
$ git pull https://git.openjdk.org/jdk pull/10459/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10459
View PR using the GUI difftool:
$ git pr show -t 10459
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10459.diff