Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255858: Add debug agent support for storing thread names #1047

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Nov 3, 2020

Simple change to add a name field to ThreadNode to aide when debugging the debug agent. It's off by default. You need to add a #define DEBUG_THREADNAME to enable it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255858: Add debug agent support for storing thread names

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1047/head:pull/1047
$ git checkout pull/1047

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2020

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 3, 2020

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 3, 2020
@plummercj plummercj changed the title Add support for tracking a thread's name. 8255858: Add debug agent support for storing thread names Nov 4, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2020

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris,
It looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Nov 4, 2020

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255858: Add debug agent support for storing thread names

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • a0ade22: 8255900: x86: Reduce impact when VerifyOops is disabled
  • 29db1dc: 8255886: Shenandoah: Resolve cset address truncation and register clash in interpreter LRB
  • 26e7ef7: 8252870: Finalize (remove "incubator" from) jpackage
  • 804bd72: 8255128: linux x86 build failure with libJNIPoint.c
  • 160759c: 8255838: Use 32-bit immediate movslq in macro assembler if 64-bit value fits in 32 bits on x86_64
  • 94ace03: 8255863: Clean up test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java
  • 2da9981: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe
  • 5348298: 8255855: appcds/jigsaw/NewModuleFinderTest.java test failed due to unexpected NPE
  • c287170: 8254742: InputStream::readNBytes(int) result may contain zeros not in input
  • 7dcaba6: 8253892: Disable misleading-indentation on clang as well as gcc
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/184db64dfb711c9cba426fb0b45bea4c962489de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2020
@plummercj
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Nov 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2020
@openjdk
Copy link

openjdk bot commented Nov 4, 2020

@plummercj Since your change was applied there have been 55 commits pushed to the master branch:

  • a0ade22: 8255900: x86: Reduce impact when VerifyOops is disabled
  • 29db1dc: 8255886: Shenandoah: Resolve cset address truncation and register clash in interpreter LRB
  • 26e7ef7: 8252870: Finalize (remove "incubator" from) jpackage
  • 804bd72: 8255128: linux x86 build failure with libJNIPoint.c
  • 160759c: 8255838: Use 32-bit immediate movslq in macro assembler if 64-bit value fits in 32 bits on x86_64
  • 94ace03: 8255863: Clean up test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java
  • 2da9981: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe
  • 5348298: 8255855: appcds/jigsaw/NewModuleFinderTest.java test failed due to unexpected NPE
  • c287170: 8254742: InputStream::readNBytes(int) result may contain zeros not in input
  • 7dcaba6: 8253892: Disable misleading-indentation on clang as well as gcc
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/184db64dfb711c9cba426fb0b45bea4c962489de...master

Your commit was automatically rebased without conflicts.

Pushed as commit 166c728.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this pull request Nov 4, 2020
@plummercj plummercj deleted the JDK-8255858 branch December 18, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants