Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295419: JFR: Change name of jdk.JitRestart #10731

Closed
wants to merge 3 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Oct 17, 2022

Could I have a review of a change to the JFR event metadata.

The convention used by JFR events have been to use uppercase for acronyms, for example CPULoad, TLSHandshake, SystemGC, JVMInformation and ObjectAllocationInNewTLAB. The jdk.JitRestart event should follow the same convention to be consistent (jdk.JITRestart). The event has not been in a release so there is no harm in changing.

Testing: test/jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10731/head:pull/10731
$ git checkout pull/10731

Update a local copy of the PR:
$ git checkout pull/10731
$ git pull https://git.openjdk.org/jdk pull/10731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10731

View PR using the GUI difftool:
$ git pr show -t 10731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10731.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 17, 2022
@egahlin
Copy link
Member Author

egahlin commented Oct 17, 2022

/label remove hotspot
/label add hotspot-jfr

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@egahlin
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@egahlin
The hotspot-jfr label was successfully added.

@egahlin egahlin marked this pull request as ready for review October 17, 2022 17:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@egahlin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jitevent
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295419: JFR: Change name of jdk.JitRestart

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Oct 18, 2022
@egahlin
Copy link
Member Author

egahlin commented Oct 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

Going to push as commit ecfb6bc.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 95baf83: 8295517: Fix stutter typo in JDK-8294539
  • 37f93b6: 8295029: runtime/cds/appcds/LotsOfClasses.java fail with jfx

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2022
@openjdk openjdk bot closed this Oct 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@egahlin Pushed as commit ecfb6bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants