New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295419: JFR: Change name of jdk.JitRestart #10731
Conversation
|
/label remove hotspot |
@egahlin |
@egahlin |
@egahlin this pull request can not be integrated into git checkout jitevent
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@egahlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Could I have a review of a change to the JFR event metadata.
The convention used by JFR events have been to use uppercase for acronyms, for example CPULoad, TLSHandshake, SystemGC, JVMInformation and ObjectAllocationInNewTLAB. The jdk.JitRestart event should follow the same convention to be consistent (jdk.JITRestart). The event has not been in a release so there is no harm in changing.
Testing: test/jdk/jdk/jfr
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10731/head:pull/10731
$ git checkout pull/10731
Update a local copy of the PR:
$ git checkout pull/10731
$ git pull https://git.openjdk.org/jdk pull/10731/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10731
View PR using the GUI difftool:
$ git pr show -t 10731
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10731.diff