8295414: [Aarch64] C2: assert(false) failed: bad AD file

[dean-long]

The "bad AD file" error is because PartialSubtypeCheck produces an iRegP_R5 result, which cannot be matched as an input where iRegP is expected.
Update the test to reproduce the crash and updated iRegP rule to match iRegP_R5.
The fact that this went so long without being noticed makes me wonder how much test coverage PartialSubtypeCheck has received on aarch64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295414: [Aarch64] C2: assert(false) failed: bad AD file

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 87445222
• Christian Hagedorn (@chhagedorn - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10749/head:pull/10749
$ git checkout pull/10749

Update a local copy of the PR:
$ git checkout pull/10749
$ git pull https://git.openjdk.org/jdk pull/10749/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10749

View PR using the GUI difftool:
$ git pr show -t 10749

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10749.diff

[bridgekeeper]

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dean-long The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e472a20e)
• 00: Full (87445222)

[vnkozlov]

Good

[openjdk]

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295414: [Aarch64] C2: assert(false) failed: bad AD file

Reviewed-by: kvn, chagedorn, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 545021b: 8294438: Fix misleading-indentation warnings in hotspot
• c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
• 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
• 017e798: 8293939: Move continuation_enter_setup and friends
• f872467: 8255746: Make PrintCompilation available on a per method level
• 388a56e: 8294467: Fix sequence-point warnings in Hotspot
• ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
• 7b1c676: 8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"
• 5eaf568: 8295668: validate-source failure after JDK-8290011
• e238920: 8295372: CompactNumberFormat handling of number one with decimal part
• ... and 24 more: https://git.openjdk.org/jdk/compare/0233ba763d84e6da8ec03df5d021a13c5fbbc871...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Otherwise, looks good!

[dean-long]

Thanks Christian and Vladimir.

[dean-long]

@theRealAph, do you agree with this fix?

[dean-long]

Thanks Andrew.

[dean-long]

/integrate

[openjdk]

Going to push as commit d3eba85.
Since your change was applied there have been 49 commits pushed to the master branch:

• 028e8b3: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
• faa6b66: 8295715: Minimize disabled warnings in serviceability libs
• de1e0c5: 8295719: Remove unneeded disabled warnings in jdk.sctp
• 9612cf9: 8295529: Add link to JBS to README.md
• b37421e: 8295564: Norwegian Nynorsk Locale is missing formatting
• 6707bfb: 8029633: Raw inner class constructor ref should not perform diamond inference
• 7bc9692: 8294670: Enhanced switch statements have an implicit default which does not complete normally
• 95dd376: 8291914: generated constructors are considered compact when they shouldn't
• 9b97162: 7039014: Confusing error message for method conflict
• 78dc497: 8294550: Sealed check for casts isn't applied to array components
• ... and 39 more: https://git.openjdk.org/jdk/compare/0233ba763d84e6da8ec03df5d021a13c5fbbc871...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dean-long Pushed as commit d3eba85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.