6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel

[TejeshR13]

Tooltip is not shown for the buttons placed in left side of JFileChooser(In Windows Look And Feel), namely the shellFolder like (Recent Items, Desktop, Documents). Hence the tooltip is added for those shell folders/WindowBar when they are constructed. The Automatic test is added.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• @kumarabhi006 (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10819/head:pull/10819
$ git checkout pull/10819

Update a local copy of the PR:
$ git checkout pull/10819
$ git pull https://git.openjdk.org/jdk pull/10819/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10819

View PR using the GUI difftool:
$ git pr show -t 10819

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10819.diff

[bridgekeeper]

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TejeshR13 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (70dd1844)

[openjdk]

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 250 new commits pushed to the master branch:

• 8e5d680: 8293093: NPE in P11KeyStore.getID
• 3135914: 8265441: IGV: select block nodes by clicking on it
• 78454b6: 8295879: JFR: Remove warnings in the jdk.jfr module
• 33ff80d: 8295402: G1: Tighten assertion in G1ScanHRForRegionClosure::scan_heap_roots
• 303548b: 8294752: G1: Remove redundant checks in check_obj_during_refinement
• cf121df: 8295889: NMT preinit code does not handle allocation errors
• 772be2e: 8295868: 32-bit Windows build failures after JDK-8294466
• e173fd7: 8295885: GHA: Bump gcc versions
• b2878c9: 8295710: remove os::dll_file_extension
• e3a5a34: 8295767: Remove unused fields in sun.awt.geom.Edge
• ... and 240 more: https://git.openjdk.org/jdk/compare/8713dfa64ef4c55c8b9a3be8aab2bb5e16c627da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kumarabhi006]

Fix looks good to me.

[TejeshR13]

/integrate

[openjdk]

Going to push as commit 210fe49.
Since your change was applied there have been 254 commits pushed to the master branch:

• c2d7a35: 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out
• 58a7141: 8295066: Folding of loads is broken in C2 after JDK-8242115
• a8450b3: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows
• 46e6aee: 8295823: Use enhanced-for cycle instead of Enumeration in java.naming
• 8e5d680: 8293093: NPE in P11KeyStore.getID
• 3135914: 8265441: IGV: select block nodes by clicking on it
• 78454b6: 8295879: JFR: Remove warnings in the jdk.jfr module
• 33ff80d: 8295402: G1: Tighten assertion in G1ScanHRForRegionClosure::scan_heap_roots
• 303548b: 8294752: G1: Remove redundant checks in check_obj_during_refinement
• cf121df: 8295889: NMT preinit code does not handle allocation errors
• ... and 244 more: https://git.openjdk.org/jdk/compare/8713dfa64ef4c55c8b9a3be8aab2bb5e16c627da...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TejeshR13 Pushed as commit 210fe49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.