8295967: RISC-V: Support negVI/negVL instructions for Vector API #10880

DingliZhang · 2022-10-27T05:38:03Z

Hi,

This patch will add support of NegVI, NegVL for RISC-V and was implemented by referring to riscv-v-spec v1.0 [1].

Tests are performed on qemu with parameter -cpu rv64,v=true,vlen=256,vext_spec=v1.0. By adding the -XX:+PrintAssembly -Xcomp -XX:-TieredCompilation -XX:+LogCompilation -XX:LogFile=compile.log parameter when executing the test cases[2] [3] , the compilation log is as follows:

100     B16: #	out( B37 B17 ) &lt;- in( B15 )  Freq: 77.0109
100     # castII of R9, #@castII
100     addw  R29, R9, zr	#@convI2L_reg_reg
104     slli  R29, R29, (#2 &amp; 0x3f)	#@lShiftL_reg_imm
108     add R12, R30, R29	# ptr, #@addP_reg_reg
10c     addi  R12, R12, #16	# ptr, #@addP_reg_imm
110     vle V1, [R12]	#@loadV
118     vrsub.vx V1, V1, V1	#@vnegI
120     bgeu  R9, R10, B37	#@cmpU_branch  P=0.000001 C=-1.000000

At the same time, the following assembly code will be generated:

  0x000000400ccfa618:   .4byte	0x10072d7
  0x000000400ccfa61c:   .4byte	0xe1040d7                   ;*invokestatic unaryOp {reexecute=0 rethrow=0 return_oop=0}
                                                            ; - jdk.incubator.vector.IntVector::lanewiseTemplate@91 (line 684)
                                                            ; - jdk.incubator.vector.Int256Vector::lanewise@2 (line 273)
                                                            ; - jdk.incubator.vector.Int256Vector::lanewise@2 (line 41)
                                                            ; - Int256VectorTests::NEGInt256VectorTests@73 (line 5216)

PS: 0x10072d7/0xe1040d7 are the machine code for vsetvli/vrsub.

After we implement these nodes, by using -XX:+UseRVV, the number of assembly instructions is reduced by about ~50% because of the different execution paths with the number of loops, similar to AddTest [4].

In the meantime, I also add an assembly pseudoinstruction vneg.v in macroAssembler_riscv.

[1] https://github.com/riscv/riscv-v-spec/blob/v1.0/v-spec.adoc#111-vector-single-width-integer-add-and-subtract
[2] https://github.com/openjdk/jdk/tree/master/test/jdk/jdk/incubator/vector/Int256VectorTests.java
[3] https://github.com/openjdk/jdk/tree/master/test/jdk/jdk/incubator/vector/Long256VectorTests.java
[4] https://github.com/zifeihan/vector-api-test-rvv/blob/master/vector-api-rvv-performance.md

Please take a look and have some reviews. Thanks a lot.

Testing:

hotspot and jdk tier1 on unmatched board without new failures
test/jdk/jdk/incubator/vector/Int256VectorTests.java with fastdebug on qemu
test/jdk/jdk/incubator/vector/Long256VectorTests.java with fastdebug on qemu

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8295967: RISC-V: Support negVI/negVL instructions for Vector API

Reviewers

Yadong Wang (@yadongw - Author)
Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10880/head:pull/10880
$ git checkout pull/10880

Update a local copy of the PR:
$ git checkout pull/10880
$ git pull https://git.openjdk.org/jdk pull/10880/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10880

View PR using the GUI difftool:
$ git pr show -t 10880

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10880.diff

bridgekeeper · 2022-10-27T05:38:17Z

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-10-27T05:40:43Z

@DingliZhang The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-10-27T05:43:27Z

Webrevs

00: Full (abaa0414)

yadongw

lgtm

RealFYang

Looks good. Thanks.

openjdk · 2022-11-04T08:28:24Z

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295967: RISC-V: Support negVI/negVL instructions for Vector API

Reviewed-by: yadongwang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

9d3b4ef: 8296108: (tz) Update Timezone Data to 2022f
4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
f43bb9f: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics
b685fc2: 8295685: Update Libpng to 1.6.38
94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
4338f52: 8294241: Deprecate URL public constructors
68209ad: 8288232: Address typos in jar man page
... and 72 more: https://git.openjdk.org/jdk/compare/c2d7a35a4b3ec7d9c567cdd98c2db958c4b2e9d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

DingliZhang · 2022-11-04T08:57:09Z

@yadongw @RealFYang Thanks for the review!
/integrate

openjdk · 2022-11-04T08:58:15Z

@DingliZhang
Your change (at version abaa041) is now ready to be sponsored by a Committer.

RealFYang · 2022-11-04T09:07:30Z

/sponsor

openjdk · 2022-11-04T09:08:39Z

Going to push as commit c116ae7.
Since your change was applied there have been 82 commits pushed to the master branch:

9d3b4ef: 8296108: (tz) Update Timezone Data to 2022f
4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
f43bb9f: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics
b685fc2: 8295685: Update Libpng to 1.6.38
94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
4338f52: 8294241: Deprecate URL public constructors
68209ad: 8288232: Address typos in jar man page
... and 72 more: https://git.openjdk.org/jdk/compare/c2d7a35a4b3ec7d9c567cdd98c2db958c4b2e9d2...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-04T09:08:58Z

@RealFYang @DingliZhang Pushed as commit c116ae7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Add vnegI/vnegL C2 instructions for Vector api

abaa041

openjdk bot added the rfr Pull request is ready for review label Oct 27, 2022

openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 27, 2022

yadongw approved these changes Nov 4, 2022

View reviewed changes

RealFYang approved these changes Nov 4, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 4, 2022

openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022

openjdk bot closed this Nov 4, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8295967: RISC-V: Support negVI/negVL instructions for Vector API #10880

8295967: RISC-V: Support negVI/negVL instructions for Vector API #10880

DingliZhang commented Oct 27, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Oct 27, 2022

openjdk bot commented Oct 27, 2022

mlbridge bot commented Oct 27, 2022

yadongw left a comment

RealFYang left a comment

openjdk bot commented Nov 4, 2022

DingliZhang commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

RealFYang commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

8295967: RISC-V: Support negVI/negVL instructions for Vector API #10880

8295967: RISC-V: Support negVI/negVL instructions for Vector API #10880

Conversation

DingliZhang commented Oct 27, 2022 • edited by openjdk bot Loading

Testing:

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 27, 2022

openjdk bot commented Oct 27, 2022

mlbridge bot commented Oct 27, 2022

Webrevs

yadongw left a comment

Choose a reason for hiding this comment

RealFYang left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 4, 2022

DingliZhang commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

RealFYang commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

openjdk bot commented Nov 4, 2022

DingliZhang commented Oct 27, 2022 •

edited by openjdk bot

Loading