Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296758: [BACKOUT] Revert 8296115 #11077

Closed
wants to merge 4 commits into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Nov 10, 2022

8296115 unfortunately did not prove to be as useful as expected, revert it and reopen 8241499 for a future change (which I'll likely address soon).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11077/head:pull/11077
$ git checkout pull/11077

Update a local copy of the PR:
$ git checkout pull/11077
$ git pull https://git.openjdk.org/jdk pull/11077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11077

View PR using the GUI difftool:
$ git pr show -t 11077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11077.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2022

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8296758 8296758: [BACKOUT] Revert 8296115 Nov 10, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@TheShermanTanker The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 10, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2022

Webrevs

@magicus
Copy link
Member

magicus commented Nov 10, 2022

Can you remove the Support for checking standards conforming code addition to the build documentation as well?

@TheShermanTanker
Copy link
Contributor Author

Can you remove the Support for checking standards conforming code addition to the build documentation as well?

Oops - forgot about that, will do in a moment

@TheShermanTanker
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296758: [BACKOUT] Revert 8296115

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 4465361: 8295948: Support for Zicbop/prefetch instructions on RISC-V
  • f2acdfd: 8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT
  • bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
  • e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
  • 78a08a0: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop
  • f0a6e71: 8295812: Skip the "half float" support in LittleCMS during the build
  • 79c0092: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@TheShermanTanker
Your change (at version 675b6d7) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

magicus commented Nov 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

Going to push as commit f0b648b.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 7f587e5: 8296872: gtest is built with the build-jdk
  • 819c691: 8295867: TestVerifyGraphEdges.java fails with exit code -1073741571 when using AlwaysIncrementalInline
  • ced88a2: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 87b809a: 8296229: JFR: jfr tool should print unsigned values correctly
  • e7c2a8e: 8295214: Generational ZGC: Guard nmethods from cross modifying code
  • d4d183e: 8296301: Interpreter(RISC-V): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
  • f754840: 8296773: G1: Factor out hash function for G1CardSet
  • fdabd37: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup"
  • 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
  • 12e76cb: 8296349: [aarch64] Avoid slicing Address::extend
  • ... and 19 more: https://git.openjdk.org/jdk/compare/0981bfb1a317466c095c392f82ddf6eae595f4af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2022
@openjdk openjdk bot closed this Nov 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@magicus @TheShermanTanker Pushed as commit f0b648b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the patch-1 branch November 12, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants