8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException

[djelinski]

This patch fixes the exceptions that may occur when merging IP address NameConstraints from different certificates in a chain.

The included test reports 3 exceptions without the fix, passes with the fix applied.

Tiers 1-3 continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11459/head:pull/11459
$ git checkout pull/11459

Update a local copy of the PR:
$ git checkout pull/11459
$ git pull https://git.openjdk.org/jdk pull/11459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11459

View PR using the GUI difftool:
$ git pr show -t 11459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11459.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d4467058)

[seanjmullan]

Looks good.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 19d8498: 8297495: j.u.concurrent updates for JDK 20
• 3288459: 8297606: [AIX] Broken build after JDK-8295475
• 0452c39: 8296477: Foreign linker implementation update following JEP 434
• 73baadc: 8295044: Implementation of Foreign Function and Memory API (Second Preview)
• bd38188: 8297766: Remove UseMallocOnly development option
• b9eec96: 8281214: Unsafe use of long in VMThread::setup_periodic_safepoint_if_needed
• e7e0354: 8297767: Assert JNICritical_lock/safepoint-1 and AdapterHandlerLibrary_lock/safepoint-1
• f9e0f1d: 8297763: Fix missing stub code expansion before align() in shared trampolines
• 2300ed4: 8291769: Translation of switch with record patterns could be improved
• eab0ada: 8296545: C2 Blackholes should allow load optimizations
• ... and 56 more: https://git.openjdk.org/jdk/compare/cd776093c79e9a1a4c40c0adfdbfeedf293d99c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[djelinski]

/integrate

[openjdk]

Going to push as commit 2a243a3.
Since your change was applied there have been 82 commits pushed to the master branch:

• 923c746: 8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY
• 0bd04a6: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
• f5ad515: 8297247: Add GarbageCollectorMXBean for Remark and Cleanup pause time in G1
• e975418: 8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done
• 04012c4: 8298111: Cleanups after UseMallocOnly removal
• ee9ba74: 8295184: Printing messages with a RecordComponentElement does not include position
• ba2d28e: 8298027: Remove SCCS id's from awt jtreg tests
• 8d8a28f: 8296489: tools/jpackage/windows/WinL10nTest.java fails with timeout
• 884b9ad: 8293453: tools/jpackage/share/AddLShortcutTest.java "Failed: Check the number of mismatched pixels [1024] of [1024] is < [0.100000] threshold"
• 8af6e8a: 8298123: Problem List MaximizedToIconified.java on macOS
• ... and 72 more: https://git.openjdk.org/jdk/compare/cd776093c79e9a1a4c40c0adfdbfeedf293d99c7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 2a243a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.