8255990: Bitmap region of dynamic CDS archive is not unmapped

[calvinccheung]

Add the missing call to unmap_region to unmap the bitmap region of a dynamic CDS archive.

Also modify the DynamicArchiveRelocationTest to check for the "Unmapping region" message.

Testing:

• tier1
• tiers 2,3,4 (in progress)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255990: Bitmap region of dynamic CDS archive is not unmapped

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Yumin Qi (@yminqi - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1151/head:pull/1151
$ git checkout pull/1151

[calvinccheung]

/label remove hotspot

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung The hotspot label was not set.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (9dbdb3e)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255990: Bitmap region of dynamic CDS archive is not unmapped

Reviewed-by: iklam, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• ccb48b7: 8248188: Add IntrinsicCandidate and API for Base64 decoding
• 59965c1: 8256237: Zero: non-PCH build fails after JDK-8253064
• bfa060f: 8256051: nmethod_entry_barrier stub miscalculates xmm spill size on x86_32
• 96e0261: 8256106: Bypass intrinsic/barrier when calling Reference.get() from Finalizer
• 3c3469b: 8256020: Shenandoah: Don't resurrect objects during evacuation on AS_NO_KEEPALIVE
• 2e19026: 8253064: monitor list simplifications and getting rid of TSM
• 421a7c3: 8256182: Update qemu-debootstrap cross-compilation recipe
• 6247736: 8256018: Adler32/CRC32/CRC32C missing reachabilityFence
• 436019b: 8256166: [C2] Registers get confused on Big Endian after 8221404
• ed615e3: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper
• ... and 36 more: https://git.openjdk.java.net/jdk/compare/17f04fc9e755a83727ac9d13a39b487f99311efd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yminqi]

Looks good!

[calvinccheung]

@iklam, @yminqi, Thanks for your reviews!

[calvinccheung]

/integrate

[openjdk]

@calvinccheung Since your change was applied there have been 56 commits pushed to the master branch:

• 943acd2: 8256276: Temporarily disable gtest special_flags
• 19bade0: 8256238: Remove Matcher::pass_original_key_for_aes
• f7685a4: 8256203: Simplify RegMask::Empty
• 70c7b1d: 8250607: C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops
• bd8693a: 8256181: Remove Allocation of old generation on alternate memory devices functionality
• 4df8abc: 8255787: Tag container tests that use cGroups with cgroups keyword
• ec08b3f: 8256188: Adjust output of make/autoconf/configure
• da48003: 8255975: Fix AArch64 OpenJDK build failure with gcc-5
• 14e25e2: 8255982: Extend BasicJMapTest to test with different GC Heap
• 2f06893: 8252526: Remove excessive inclusion of jvmti.h and jvmtiExport.hpp
• ... and 46 more: https://git.openjdk.java.net/jdk/compare/17f04fc9e755a83727ac9d13a39b487f99311efd...master

Your commit was automatically rebased without conflicts.

Pushed as commit c6ab0fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.