8256220: C1: x86_32 fails with -XX:UseSSE=1 after JDK-8210764 due to mishandled lir_neg

[shipilev]

This failure manifests on many tests in tier1:

$ CONF=linux-x86-server-fastdebug make images run-test TEST=tier1 TEST_VM_OPTS="-XX:UseSSE=1"

# Internal Error (/home/shade/trunks/jdk/src/hotspot/cpu/x86/c1_LinearScan_x86.cpp:794), pid=1484789, tid=1484820
# assert(false) failed: missed a fpu-operation
#
# JRE version: OpenJDK Runtime Environment (16.0) (fastdebug build 16-internal+0-adhoc.shade.jdk)
# Java VM: OpenJDK Server VM (fastdebug 16-internal+0-adhoc.shade.jdk, mixed mode, tiered, g1 gc, linux-x86)
# Problematic frame:
# V [libjvm.so+0x6d6300] FpuStackAllocator::handle_op2(LIR_Op2*)+0xf0

Amending that assert implies we miss "neg". I believe it was missed when JDK-8210764 changed lir_neg from LIR_Op1 to LIR_Op2. At first I just moved the block to appropriate switch that handles op2, but then I realized lir_neg code is basically the same as for lir_abs in the same switch.

Testing:

• Linux x86_32 fastdebug tier1 with -XX:UseSSE=0 (some leftover failures)
• Linux x86_32 fastdebug tier1 with -XX:UseSSE=1 (some leftover failures)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8256220: C1: x86_32 fails with -XX:UseSSE=1 after JDK-8210764 due to mishandled lir_neg

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1173/head:pull/1173
$ git checkout pull/1173

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1cd78b9)

[chhagedorn]

Yes, that block seems to do the same - looks good to me!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256220: C1: x86_32 fails with -XX:UseSSE=1 after JDK-8210764 due to mishandled lir_neg

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks!

/integrate

[openjdk]

@shipilev Since your change was applied there have been 15 commits pushed to the master branch:

• 1d3d64f: 8255973: Add more logging to debug JDK-8255917
• e32a4ea: 8253820: Save test images and dumps with timestamps from client sanity suite
• dff26a4: 8256063: Module::getPackages on an unnamed module may return packages that are in a named module
• 531c56e: 8256278: Shenandoah: Avoid num of dead callback from weak processor in Shenandoah root verifier
• b5a9c92: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1
• 90f9a70: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU
• 1c0b490: 8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed
• 3e70aac: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)
• c6ab0fd: 8255990: Bitmap region of dynamic CDS archive is not unmapped
• 943acd2: 8256276: Temporarily disable gtest special_flags
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/ec08b3f28d133c2cc8a9cb8396c5bfa36333ff98...master

Your commit was automatically rebased without conflicts.

Pushed as commit c3139ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.