8245215 Obsolete InitialBootClassLoaderMetaspaceSize and UseLargePagesInMetaspace

[hseigel]

Please review this change to obsolete options "InitialBootClassLoaderMetaspaceSize and UseLargePagesInMetaspace in JDK-16. The change was tested with tiers 1-2 on Linux, Windows, and MacOS, and tiers 3-5 on Linux x64. Additionally, the options were tested locally:

$JAVA_TEST/bin/java -XX:+UseLargePagesInMetaspace -version
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option UseLargePagesInMetaspace; support was removed in 16.0
java version "16-internal" 2021-03-16
...
$JAVA_TEST/bin/java -XX:InitialBootClassLoaderMetaspaceSize=4 -version
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option InitialBootClassLoaderMetaspaceSize; support was removed in 16.0
java version "16-internal" 2021-03-16
...

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8245215: Obsolete InitialBootClassLoaderMetaspaceSize and UseLargePagesInMetaspace

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1194/head:pull/1194
$ git checkout pull/1194

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3b3c001)

[lfoltan]

Looks good.
Lois

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245215: Obsolete InitialBootClassLoaderMetaspaceSize and UseLargePagesInMetaspace

Reviewed-by: lfoltan, ccheung, stuefe, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• e9956fe: 8256127: Add cross-compiled foreign architectures builds to submit workflow
• c8dd0b5: 8256320: ZGC: Update zDebug to support UseCompressedClassPointers
• 5973e91: 8253005: Add @throws IOException in javadoc for HttpEchange.sendResponseHeaders
• 8c31bd2: 8256275: Optimized build is broken
• b0c28fa: 8256011: Shenandoah: Don't resurrect finalizably reachable objects
• 41139e3: 8255964: Add all details to jstack log in jtreg timeout handler
• b4d0186: 8253525: Implement getInstanceSize/sizeOf intrinsics
• ea576dd: 8254887: C2: assert(cl->trip_count() > 0) failed: peeling a fully unrolled loop
• 05b8245: 8256290: javac/lambda/T8031967.java fails with StackOverflowError on x86_32
• c3139ab: 8256220: C1: x86_32 fails with -XX:UseSSE=1 after JDK-8210764 due to mishandled lir_neg
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/b5a9c92b7a783aa3c99877fd055ed3c8da2ba301...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

LGTM

[hseigel]

Thanks Lois and Calvin for the reivews!

[tstuefe]

LGTM. Thanks for taking care of this.

Cheers, Thomas

[coleenp]

thanks for fixing this!

[hseigel]

/integrate

[hseigel]

Thanks Thomas and Coleen for reviewing this.

[openjdk]

@hseigel Since your change was applied there have been 14 commits pushed to the master branch:

• e9956fe: 8256127: Add cross-compiled foreign architectures builds to submit workflow
• c8dd0b5: 8256320: ZGC: Update zDebug to support UseCompressedClassPointers
• 5973e91: 8253005: Add @throws IOException in javadoc for HttpEchange.sendResponseHeaders
• 8c31bd2: 8256275: Optimized build is broken
• b0c28fa: 8256011: Shenandoah: Don't resurrect finalizably reachable objects
• 41139e3: 8255964: Add all details to jstack log in jtreg timeout handler
• b4d0186: 8253525: Implement getInstanceSize/sizeOf intrinsics
• ea576dd: 8254887: C2: assert(cl->trip_count() > 0) failed: peeling a fully unrolled loop
• 05b8245: 8256290: javac/lambda/T8031967.java fails with StackOverflowError on x86_32
• c3139ab: 8256220: C1: x86_32 fails with -XX:UseSSE=1 after JDK-8210764 due to mishandled lir_neg
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/b5a9c92b7a783aa3c99877fd055ed3c8da2ba301...master

Your commit was automatically rebased without conflicts.

Pushed as commit 56ea786.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.