8041676: remove the java.compiler system property #13475

jaikiran · 2023-04-14T12:19:41Z

Can I please get a review of this change which removes the java.compiler system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.

A CSR has been filed for this change and is available at https://bugs.openjdk.org/browse/JDK-8305998. The CSR has more details about this proposed change, but to summarize, the java.compiler system property wasn't used in any practical way. With the recent removal of java.lang.Compiler interface from the JDK, the presence of this system property wasn't of any practical importance.

The commit in this PR, removes its reference from the System.getProperties() documentation and also removes the specific implementation from hotspot where it treated the values NONE and empty string in the absence of -Xdebug in a specific manner and considered it to be an instruction to run the application in interpreter-only mode. -Xint option has been around for this purpose, so removal of this java.compiler system property support from hotspot implementation wouldn't remove any usable feature for the applications.

Additionally, the hotspot implementation now logs a warning message when it detects the presence of java.compiler system property when java is launched. This warning message will be removed after a few releases.

The current JDK source has reference to the java.compiler system property in numerous NetBeans project build files. The usage of this system property in such files isn't necessary. However, this PR doesn't intend to cleanup those references, since it isn't clear which of those NetBeans projects are still relevant. I think we can use a separate PR to do that cleanup.

tier1, tier2, tier3 testing has been done with these changes and those tests have passed.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8305998 to be approved

Issues

JDK-8041676: remove the java.compiler system property
JDK-8305998: remove the java.compiler system property (CSR)

Reviewers

David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 3a4bf8f7
Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 3a4bf8f7
Roger Riggs (@RogerRiggs - Reviewer)
Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13475/head:pull/13475
$ git checkout pull/13475

Update a local copy of the PR:
$ git checkout pull/13475
$ git pull https://git.openjdk.org/jdk.git pull/13475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13475

View PR using the GUI difftool:
$ git pr show -t 13475

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13475.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-04-14T12:20:59Z

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-14T12:24:14Z

@jaikiran The following labels will be automatically applied to this pull request:

core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-14T12:28:33Z

Webrevs

01: Full - Incremental (5c1846e1)
00: Full (3a4bf8f7)

dholmes-ora

Code changes look good. Thanks for cleaning this up.

AlanBateman · 2023-04-14T13:28:40Z

src/hotspot/share/runtime/arguments.cpp

+        warning("The java.compiler system property is obsolete and no longer supported,"
+                " use -Xint if you want to run the application in interpreted-only mode.");
+    } else {
+        warning("The java.compiler system property is obsolete and no longer supported.");


This looks okay although the warning for the empty value and "NONE" case will probably wrap as it's very long. Today, -Djava.compiler=foo is ignored, no warning, seems good to emit a warning about that too.

Hello Alan,

This looks okay although the warning for the empty value and "NONE" case will probably wrap as it's very long.

Agreed, it's a bit long. I can't think of a simpler message though. If anyone has a suggestion, I'll update accordingly.

Just drop the detailed explanation, they can check the help for -Xint.

"The java.compiler system property is obsolete and no longer supported, use -Xint".

Thank you Roger, updated the PR with this suggested change.

openjdk · 2023-04-19T16:51:36Z

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8041676: remove the java.compiler system property

Reviewed-by: dholmes, alanb, rriggs, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

4ad3ac6: 8306135: Clean up and open source some AWT tests
85de01e: 8306323: Update license files in CLDR v43
48fd4f2: 8303431: [JVMCI] libgraal annotation API
c57af31: 8306038: SystemModulesPlugin generates code that doesn't pop when return value not used
a31a11f: 8306006: strace001.java fails due to unknown methods on stack
ddb8646: 8306123: Move InstanceKlass writeable flags
1a41e12: 8306310: Move is_shared Klass flag
c738c8e: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967
9fb53ad: 8305716: Enhancements for printing age tables
ebba42a: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
... and 58 more: https://git.openjdk.org/jdk/compare/12358e6c94bc96e618efc3ec5299a2cfe1b4669d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jaikiran · 2023-04-20T01:48:13Z

Thank you everyone for the reviews. The CSR has been approved, I'll go ahead and integrate this.

jaikiran · 2023-04-20T01:48:38Z

/integrate

openjdk · 2023-04-20T01:49:43Z

Going to push as commit b8f0a66.
Since your change was applied there have been 73 commits pushed to the master branch:

781d6d7: 8306372: Open source AWT CardLayout and Checkbox tests
d03128d: 8306280: Open source several choice AWT tests
e764e9b: 8306452: Fix Amazon copyright in JDK-8305425 test
ed34e7f: 8306321: Add an accessor for the top of a PLAB
fdb4baf: 8306134: Open source some AWT tests relating to Button and a few other classes
4ad3ac6: 8306135: Clean up and open source some AWT tests
85de01e: 8306323: Update license files in CLDR v43
48fd4f2: 8303431: [JVMCI] libgraal annotation API
c57af31: 8306038: SystemModulesPlugin generates code that doesn't pop when return value not used
a31a11f: 8306006: strace001.java fails due to unknown methods on stack
... and 63 more: https://git.openjdk.org/jdk/compare/12358e6c94bc96e618efc3ec5299a2cfe1b4669d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-20T01:49:57Z

@jaikiran Pushed as commit b8f0a66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8041676: remove the java.compiler system property

3a4bf8f

openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 14, 2023

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Apr 14, 2023

dholmes-ora approved these changes Apr 14, 2023

View reviewed changes

AlanBateman approved these changes Apr 14, 2023

View reviewed changes

RogerRiggs approved these changes Apr 14, 2023

View reviewed changes

Roger's suggestion - improve warning message

5c1846e

RogerRiggs approved these changes Apr 14, 2023

View reviewed changes

irisclark approved these changes Apr 14, 2023

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Apr 19, 2023

openjdk bot added the integrated Pull request has been integrated label Apr 20, 2023

openjdk bot closed this Apr 20, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2023

jaikiran deleted the 8041676 branch April 20, 2023 01:52

eirbjo mentioned this pull request Apr 20, 2023

8304503: Modernize debugging jvm args in demo netbeans projects #13101

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8041676: remove the java.compiler system property #13475

8041676: remove the java.compiler system property #13475

jaikiran commented Apr 14, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 14, 2023

openjdk bot commented Apr 14, 2023

mlbridge bot commented Apr 14, 2023 •

edited

Loading

dholmes-ora left a comment

AlanBateman Apr 14, 2023

jaikiran Apr 14, 2023

RogerRiggs Apr 14, 2023

jaikiran Apr 14, 2023

openjdk bot commented Apr 19, 2023 •

edited

Loading

jaikiran commented Apr 20, 2023

jaikiran commented Apr 20, 2023

openjdk bot commented Apr 20, 2023

openjdk bot commented Apr 20, 2023

8041676: remove the java.compiler system property #13475

8041676: remove the java.compiler system property #13475

Conversation

jaikiran commented Apr 14, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 14, 2023

openjdk bot commented Apr 14, 2023

mlbridge bot commented Apr 14, 2023 • edited Loading

Webrevs

dholmes-ora left a comment

Choose a reason for hiding this comment

AlanBateman Apr 14, 2023

Choose a reason for hiding this comment

jaikiran Apr 14, 2023

Choose a reason for hiding this comment

RogerRiggs Apr 14, 2023

Choose a reason for hiding this comment

jaikiran Apr 14, 2023

Choose a reason for hiding this comment

openjdk bot commented Apr 19, 2023 • edited Loading

jaikiran commented Apr 20, 2023

jaikiran commented Apr 20, 2023

openjdk bot commented Apr 20, 2023

openjdk bot commented Apr 20, 2023

jaikiran commented Apr 14, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 14, 2023 •

edited

Loading

openjdk bot commented Apr 19, 2023 •

edited

Loading