Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256813: Simplify WeakProcessor counting of OopStorage entries #1362

Closed
wants to merge 4 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 21, 2020

Please review this change to WeakProcessor's counting of weak and dead
entries. After JDK-8212879 we no longer need different closure classes to
deal with the serial and oopstorage cases, since the serial case no longer
exists. We can collapse that down to one closure class that is tailored for
the remaining uses.

Also deleted a stale comment left over from JDK-8212879.

Testing:
mach5 tier1
Locally (linux-x64) hotspot:tier1 with Serial and Parallel GCs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256813: Simplify WeakProcessor counting of OopStorage entries

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1362/head:pull/1362
$ git checkout pull/1362

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 21, 2020

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 21, 2020

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 21, 2020
@kimbarrett kimbarrett marked this pull request as ready for review Nov 21, 2020
@openjdk openjdk bot added the rfr label Nov 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 21, 2020

Webrevs

Copy link
Contributor

@kstefanj kstefanj left a comment

Nice cleanup, but I have one question around the accounting below.

src/hotspot/share/gc/shared/weakProcessor.inline.hpp Outdated Show resolved Hide resolved
Copy link
Member

@stefank stefank left a comment

Looks good, but would like to get StefanJ's question resolved.

src/hotspot/share/gc/shared/weakProcessor.hpp Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2020

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256813: Simplify WeakProcessor counting of OopStorage entries

Reviewed-by: sjohanss, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 67a9590: 8256614: AArch64: Add SVE backend implementation for integer min/max

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 23, 2020
Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good!

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Nov 24, 2020

Thanks @kstefanj and @stefank for reviews.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Nov 24, 2020

/integrate

@openjdk openjdk bot closed this Nov 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2020

@kimbarrett Since your change was applied there has been 1 commit pushed to the master branch:

  • 67a9590: 8256614: AArch64: Add SVE backend implementation for integer min/max

Your commit was automatically rebased without conflicts.

Pushed as commit cc96b0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the simplify_dead_count branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants