Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307078: Opensource and clean up five more AWT Focus related tests #13710

Closed
wants to merge 1 commit into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Apr 28, 2023

Cleaned up and ready to opensource:
java/awt/Focus/FocusForRemovedComponentTest
java/awt/Focus/FocusTraversalPolicyIAE
java/awt/Focus/InitialFocusTest
java/awt/Focus/LabelScrollbar
java/awt/Focus/ModalDialogInFocusEventTest


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307078: Opensource and clean up five more AWT Focus related tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13710/head:pull/13710
$ git checkout pull/13710

Update a local copy of the PR:
$ git checkout pull/13710
$ git pull https://git.openjdk.org/jdk.git pull/13710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13710

View PR using the GUI difftool:
$ git pr show -t 13710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13710.diff

Webrev

Link to Webrev Comment

Cleaned up and ready to opensource:
java/awt/Focus/FocusForRemovedComponentTest
java/awt/Focus/FocusTraversalPolicyIAE
java/awt/Focus/InitialFocusTest
java/awt/Focus/LabelScrollbar
java/awt/Focus/ModalDialogInFocusEventTest
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2023

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 28, 2023
Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, please confirm that mach5 is green.

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307078: Opensource and clean up five more AWT Focus related tests

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 187 new commits pushed to the master branch:

  • 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
  • f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
  • 82ccfe3: 8305975: Add TWCA Global Root CA
  • a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
  • e119658: 8303475: potential null pointer dereference in filemap.cpp
  • cf799ba: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock
  • 485a069: 8306432: Open source several AWT Text Component related tests
  • 169a7c2: 8306640: Open source several AWT TextArea related tests
  • 5d9baa2: 8306672: support offset in dll_address_to_library_name on AIX
  • ... and 177 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2023
@azuev-java
Copy link
Member Author

Looks fine, please confirm that mach5 is green.

Mach5 is green.

@mlbridge
Copy link

mlbridge bot commented Apr 28, 2023

Webrevs

@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

Going to push as commit 6d6f726.
Since your change was applied there have been 187 commits pushed to the master branch:

  • 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
  • f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
  • 82ccfe3: 8305975: Add TWCA Global Root CA
  • a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
  • e119658: 8303475: potential null pointer dereference in filemap.cpp
  • cf799ba: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock
  • 485a069: 8306432: Open source several AWT Text Component related tests
  • 169a7c2: 8306640: Open source several AWT TextArea related tests
  • 5d9baa2: 8306672: support offset in dll_address_to_library_name on AIX
  • ... and 177 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2023
@openjdk openjdk bot closed this Apr 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@azuev-java Pushed as commit 6d6f726.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants