Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8308872: enhance logging and some exception in krb5/Config.java #14151

Closed
wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 25, 2023

There exists already some logging in krb5/Config.java (enabled by -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis of problems. Additionally some exception(s) might be slightly adjusted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308872: enhance logging and some exception in krb5/Config.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14151/head:pull/14151
$ git checkout pull/14151

Update a local copy of the PR:
$ git checkout pull/14151
$ git pull https://git.openjdk.org/jdk.git pull/14151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14151

View PR using the GUI difftool:
$ git pr show -t 14151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14151.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 25, 2023
@mlbridge
Copy link

mlbridge bot commented May 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 31, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308872: enhance logging and some exception in krb5/Config.java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 024d9b1: 8308910: Allow executeAndLog to accept running process
  • 25b9803: 8308917: C2 SuperWord::output: assert before bailout with CountedLoopReserveKit
  • d66b6d8: 8308765: RISC-V: Expand size of stub routines for zgc only
  • 4aea7da: 8309120: java/net/httpclient/AsyncShutdownNow.java fails intermittently
  • a990322: 8309111: Removing unused constructor of PerfLongCounter and PerfLongVariable
  • 4f3a95a: 8309054: Parsing of erroneous patterns succeeds
  • 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
  • 8823626: 8309048: Remove malloc locker test case
  • 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
  • 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
  • ... and 60 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2023
@MBaesken
Copy link
Member Author

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit 70670b4.
Since your change was applied there have been 70 commits pushed to the master branch:

  • 024d9b1: 8308910: Allow executeAndLog to accept running process
  • 25b9803: 8308917: C2 SuperWord::output: assert before bailout with CountedLoopReserveKit
  • d66b6d8: 8308765: RISC-V: Expand size of stub routines for zgc only
  • 4aea7da: 8309120: java/net/httpclient/AsyncShutdownNow.java fails intermittently
  • a990322: 8309111: Removing unused constructor of PerfLongCounter and PerfLongVariable
  • 4f3a95a: 8309054: Parsing of erroneous patterns succeeds
  • 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
  • 8823626: 8309048: Remove malloc locker test case
  • 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
  • 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
  • ... and 60 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@MBaesken Pushed as commit 70670b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants