Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309937: Add @sealedGraph for some Panama FFM interfaces #14449

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Jun 13, 2023

This PR proposes adding @sealedGraph to GroupLayout so the latter will be rendered in the javadocs the same way the other layouts that has public sub-interfaces.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309937: Add @sealedGraph for some Panama FFM interfaces (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14449/head:pull/14449
$ git checkout pull/14449

Update a local copy of the PR:
$ git checkout pull/14449
$ git pull https://git.openjdk.org/jdk.git pull/14449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14449

View PR using the GUI difftool:
$ git pr show -t 14449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14449.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309937: Add @sealedGraph for some Panama FFM interfaces

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • fb024fd: 8248149: G1: change _cleaning_claimed from int to bool
  • c2b043e: 8310183: Update GitHub Actions to use boot JDK for building jtreg
  • 238c51e: 8293069: Make -XX:+Verbose less verbose
  • 8c9b85a: 8303916: ThreadLists.java inconsistent results
  • 227656f: 8309408: Thread.sleep cleanup
  • 32243ef: 8310128: Switch with unnamed patterns erroneously non-exhaustive
  • cfae6ef: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • db133db: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • 353e581: 8309747: Update --release 21 symbol information for JDK 21 build 27
  • d3d0dbc: 8309756: Occasional crashes with pipewire screen capture on Wayland
  • ... and 44 more: https://git.openjdk.org/jdk/compare/6d05360bec809ac121dae7afb0e770aaa7d79401...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@minborg
Copy link
Contributor Author

minborg commented Jun 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit b412fc7.
Since your change was applied there have been 54 commits pushed to the master branch:

  • fb024fd: 8248149: G1: change _cleaning_claimed from int to bool
  • c2b043e: 8310183: Update GitHub Actions to use boot JDK for building jtreg
  • 238c51e: 8293069: Make -XX:+Verbose less verbose
  • 8c9b85a: 8303916: ThreadLists.java inconsistent results
  • 227656f: 8309408: Thread.sleep cleanup
  • 32243ef: 8310128: Switch with unnamed patterns erroneously non-exhaustive
  • cfae6ef: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • db133db: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • 353e581: 8309747: Update --release 21 symbol information for JDK 21 build 27
  • d3d0dbc: 8309756: Occasional crashes with pipewire screen capture on Wayland
  • ... and 44 more: https://git.openjdk.org/jdk/compare/6d05360bec809ac121dae7afb0e770aaa7d79401...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@minborg Pushed as commit b412fc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@minborg
Copy link
Contributor Author

minborg commented Jun 16, 2023

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@minborg the backport was successfully created on the branch minborg-backport-b412fc79 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b412fc79 from the openjdk/jdk repository.

The commit being backported was authored by Per Minborg on 16 Jun 2023 and was reviewed by Maurizio Cimadamore.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git minborg-backport-b412fc79:minborg-backport-b412fc79
$ git checkout minborg-backport-b412fc79
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git minborg-backport-b412fc79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants