-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8167252: Some of Charset.availableCharsets() does not contain itself #14473
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all right.
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine over all.
It might be worth considering updating this to use junit at some point as a separate clean up activity as it could further streamline the test
@@ -103,6 +105,24 @@ static void checkUTF() throws Exception { | |||
true); | |||
} | |||
|
|||
static void selfContainmentTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be nice to add a comment regarding the purpose of the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec is that Charset::contains return true for self so maybe it could be renamed to containsSelfTest, might help with the understanding the purpose (along with a comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will address these in the next iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved.
Hello Naoto, should |
This is JDK internal, it shouldn't leak out via the APIs. If there is a way for it to leak out then it would require a compliant contains method but I suspect it's internal only. |
Hello Alan,
You are right this is an internal class (I just found these by checking which classes extend |
Thanks for the review, Jai. |
/integrate |
Going to push as commit 3eeb681.
Your commit was automatically rebased without conflicts. |
Adding themselves into their
contains()
method will fix it.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14473/head:pull/14473
$ git checkout pull/14473
Update a local copy of the PR:
$ git checkout pull/14473
$ git pull https://git.openjdk.org/jdk.git pull/14473/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14473
View PR using the GUI difftool:
$ git pr show -t 14473
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14473.diff
Webrev
Link to Webrev Comment