Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257673: Build fails without shenandoahgc after JDK-8257563 #1594

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 3, 2020

Hi all,

Please review this one-line change, which fixes the build failure without shenandoahgc.

Testing:

  • Build tests without shenandoahgc and PCH on Linux/x64

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257673: Build fails without shenandoahgc after JDK-8257563

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1594/head:pull/1594
$ git checkout pull/1594

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Dec 3, 2020

/issue add JDK-8257673
/label add hotspot-runtime
/cc hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@DamonFool
The hotspot-runtime label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@DamonFool The hotspot-runtime label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 3, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257673: Build fails without shenandoahgc after JDK-8257563

Reviewed-by: aph, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 6c9482e: 8257561: Some code is not vectorized after 8251925 and 8250607
  • 70517c8: 8257642: CipherByteBufferOverwriteTest copyright issue
  • e836396: 8257436: [aarch64] Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on
  • b170c83: 8257591: Remove suppression of record preview related warnings in java.lang
  • 66a2e70: 8255845: Memory leak in imageFile.cpp
  • fa58671: 8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
  • 129c377: 8257594: C2 compiled checkcast of non-null object triggers endless deoptimization/recompilation cycle
  • e4497c9: 8256718: Obsolete the long term deprecated and aliased Trace flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2020
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Dec 3, 2020

Thanks @theRealAph and @shipilev for your review.
/integrate

@openjdk openjdk bot closed this Dec 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@DamonFool Since your change was applied there have been 18 commits pushed to the master branch:

  • f0b1194: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits
  • 36209b7: 8257547: Handle multiple prereqs on the same line in deps files
  • c5b32b3: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "lib.jdb.Jdb.log(String)" because "this.jdb" is null"
  • 8526947: 6508941: java.awt.Desktop.open causes VM to crash with video files sporadically
  • 7c7facc: 8257701: Shenandoah: objArrayKlass metadata is not marked with chunked arrays
  • 2b73f99: 8228615: Optional.empty doc should suggest using isEmpty
  • 805d058: 8254699: Suboptimal PreTouchParallelChunkSize defaults and limits
  • e29ee5b: 8257641: Shenandoah: Query is_at_shenandoah_safepoint() from control thread should return false
  • 55f5542: 8026976: ECParameters, Point does not match field size
  • d3f3c32: 8255742: PrintInlining as compiler directive doesn't print virtual calls
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/4a267f1bc2b025aae2cb9df7283156aeb0282406...master

Your commit was automatically rebased without conflicts.

Pushed as commit 37c7835.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the DamonFool:JDK-8257673 branch Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants