Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java #1693

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 8, 2020

There used to be failures in Shenandoah CAS handling code like that were caught by this test. Those were fixed in JDK-8255401. This change turns the test into regression test for it.

Additional testing:

  • Affected test on x86_64 fastdebug, release
  • Affected test on x86_32 fastdebug
  • Affected test on aarch64 fastdebug

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1693/head:pull/1693
$ git checkout pull/1693

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 8, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 8, 2020

/label shenandoah,zgc

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@shipilev The label zgc is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 8, 2020

/label hotspot-gc

@openjdk openjdk bot added the hotspot-gc label Dec 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@shipilev
The hotspot-gc label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2020

Webrevs

rkennke
rkennke approved these changes Dec 8, 2020
Copy link
Contributor

@rkennke rkennke left a comment

Looks good to me! Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java

Reviewed-by: rkennke, adityam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2020
Copy link
Contributor

@adityamandaleeka adityamandaleeka left a comment

LGTM

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 5, 2021

/integrate

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@shipilev Since your change was applied there have been 9 commits pushed to the master branch:

  • 3817c32: 8258534: Epsilon: clean up unused includes
  • 17d1645: 8258751: Improve ExceptionHandlerTable dump
  • dd8996c: 8258946: Fix optimization-unstable code involving signed integer overflow
  • 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
  • 2499ac3: 8259069: Fields could be final
  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers

Your commit was automatically rebased without conflicts.

Pushed as commit db6f393.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8251944-shenandoah-test-unsafe branch Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-gc integrated
3 participants