8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false

[shipilev]

Zero does not build SA (see make/autoconf/jdk-options.m4), yet the serviceability/sa tests do not know about this, because vm.hasSA is still "true" for Zero. This makes Serviceability test fail for no good reason. The tests should be skipped for Zero.

Additional testing:

• Linux x86_64 Zero serviceability/sa tests (now skipped)
• Linux x86_64 Server serviceability/sa tests (still run)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1999/head:pull/1999
$ git checkout pull/1999

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[shipilev]

/label remove core-libs
/label remove hotspot-runtime
/label add serviceability

[openjdk]

@shipilev
The core-libs label was successfully removed.

[openjdk]

@shipilev
The hotspot-runtime label was successfully removed.

[openjdk]

@shipilev
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (d2608d4)

[jerboaa]

Looks reasonable to me.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false

Reviewed-by: sgehwolf, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 090bd3a: 8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()
• 10a6b0d: 8234773: Fix ThreadsSMRSupport::_bootstrap_list
• 6f7723b: 8258792: LogCompilation: remove redundant check fixed by 8257518
• 697bf7a: 8257740: Compiler crash when compiling type annotation on multicatch inside lambda
• b549cbd: 8258481: gc.g1.plab.TestPLABPromotion fails on Linux x86
• fc1d2a1: 8259065: Optimize MessageDigest.getInstance
• 712014c: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
• 56a354e: Merge
• 677802d: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
• 1973fbe: 8039278: console.sh failed Automatically with exit code 1
• ... and 54 more: https://git.openjdk.java.net/jdk/compare/1b60acd8aa9cbf9aed9deaf16a8eb6c09b44ee55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 80 commits pushed to the master branch:

• bb247b0: 8259392: Zero error reporting is broken after JDK-8255711
• 2806bf2: 8259475: Fix bad merge in compilerOracle
• b72de3c: 8259385: Cleanup unused assignment
• 9154f64: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute
• e7c1740: 8258187: IllegalMonitorStateException in ArrayBlockingQueue
• 11d5b04: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch
• 65ca5c6: 8048109: JToggleButton does not fire actionPerformed under certain conditions
• 81db63e: 8259517: Incorrect test path in test cases
• 270014a: 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01
• 63e3bd7: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
• ... and 70 more: https://git.openjdk.java.net/jdk/compare/1b60acd8aa9cbf9aed9deaf16a8eb6c09b44ee55...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3974fd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.