New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview #2544
Conversation
…ad of instanceof once JEP 375 exits preview
👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into |
@pconcannon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Mailing list message from Remi Forax on core-libs-dev: Hi Patrick, "Iterable" is Ok as runtime type of the classical instanceof but not in a type pattern where it is a raw type, regards, ----- Mail original -----
|
Hi Remi, Well spotted. I've updated that now ... you can view the change here: 8005665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
@pconcannon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@pconcannon Since your change was applied there have been 117 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit fbe40e8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Could someone please review my changeset for JDK-8252399: 'Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview' ?
This change updates the example code displayed in the API documentation for mapMulti to use the type test pattern introduced in JEP375.
Kind regards,
Patrick
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2544/head:pull/2544
$ git checkout pull/2544