8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview

[pconcannon]

Hi,

Could someone please review my changeset for JDK-8252399: 'Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview' ?

This change updates the example code displayed in the API documentation for mapMulti to use the type test pattern introduced in JEP375.

Kind regards,
Patrick

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview

Reviewers

• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 47dd74d
• Paul Sandoz (@PaulSandoz - Reviewer) ⚠️ Review applies to 47dd74d
• Stuart Marks (@stuart-marks - Reviewer) ⚠️ Review applies to 47dd74d

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2544/head:pull/2544
$ git checkout pull/2544

[bridgekeeper]

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pconcannon The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 08: Full - Incremental (944c7d5)
• 07: Full - Incremental (c47fbf9)
• 06: Full - Incremental (47dd74d)
• 05: Full - Incremental (2429e4f)
• 04: Full - Incremental (8005665)
• 03: Full - Incremental (f700377)
• 02: Full - Incremental (8f8dfe5)
• 01: Full - Incremental (1b8ca54)
• 00: Full (3926121)

[mlbridge]

Mailing list message from Remi Forax on core-libs-dev:

Hi Patrick,

"Iterable" is Ok as runtime type of the classical instanceof but not in a type pattern where it is a raw type,
so
if (e instanceof Iterable elements) {
should be
if (e instanceof Iterable<?> elements) {

regards,
R?mi

----- Mail original -----

De: "Patrick Concannon" <pconcannon at openjdk.java.net>
?: "core-libs-dev" <core-libs-dev at openjdk.java.net>
Envoy?: Vendredi 12 F?vrier 2021 13:16:00
Objet: Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits
preview [v3]

[pconcannon]

Mailing list message from Remi Forax on core-libs-dev:

Hi Patrick,

"Iterable" is Ok as runtime type of the classical instanceof but not in a type pattern where it is a raw type,
so
if (e instanceof Iterable elements) {
should be
if (e instanceof Iterable<?> elements) {

regards,
R?mi

----- Mail original -----

De: "Patrick Concannon"
?: "core-libs-dev"
Envoy?: Vendredi 12 F?vrier 2021 13:16:00
Objet: Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits
preview [v3]

Hi Remi,

Well spotted. I've updated that now ... you can view the change here: 8005665

[dfuch]

These changes look good to me.

[openjdk]

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview

Reviewed-by: dfuchs, psandoz, smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pconcannon]

/integrate

[openjdk]

@pconcannon Since your change was applied there have been 117 commits pushed to the master branch:

• 0f2402d: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable
• 4f0a12e: 8262323: do not special case JVMCI in tiered compilation policy
• 3022baa: 8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"
• 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
• 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
• 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
• 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
• 4e94760: 8263135: unique_ptr should not be used for types that are not pointers
• f71b21b: 8263038: Optimize String.format for simple specifiers
• 14cfbda: 8261366: Add discussion of IEEE 754 to BigDecimal
• ... and 107 more: https://git.openjdk.java.net/jdk/compare/20c93b3b901806cd9d691d75c8f30398c41fec34...master

Your commit was automatically rebased without conflicts.

Pushed as commit fbe40e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.