Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262454: Handshake timeout improvements, single target, kill unfinished thread #2743

Closed
wants to merge 9 commits into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Feb 26, 2021

When executing a single target handshake we do not have a timeout.
When we timeout we should crash the thread with the non-completed handshake operation.

VM_Handshake only had one implementer so I remove it.

Passes t1-5.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262454: Handshake timeout improvements, single target, kill unfinished thread

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2743/head:pull/2743
$ git checkout pull/2743

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2021

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 26, 2021

@robehn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 26, 2021
@robehn robehn force-pushed the 8262454-hs-timeout-st branch 2 times, most recently from 95ad267 to 534aeb3 Compare Mar 8, 2021
@robehn robehn force-pushed the 8262454-hs-timeout-st branch from 534aeb3 to 64fc6b8 Compare Mar 8, 2021
@robehn robehn marked this pull request as ready for review Mar 8, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

Copy link
Contributor

@pchilano pchilano left a comment

Looks good!

@robehn
Copy link
Contributor Author

robehn commented Mar 9, 2021

Looks good!

Thanks!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Overall this looks good. I'll approve the final version.

Thanks,
David

src/hotspot/share/runtime/handshake.cpp Show resolved Hide resolved
@robehn
Copy link
Contributor Author

robehn commented Mar 10, 2021

Overall this looks good. I'll approve the final version.

Thanks,
David

Thanks!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

One typo below otherwise LGTM!

Thanks,
David

@openjdk
Copy link

openjdk bot commented Mar 10, 2021

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262454: Handshake timeout improvements, single target, kill unfinished thread

Reviewed-by: pchilanomate, dholmes, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • f3bd801: 8263403: [JVMCI] output written to tty via HotSpotJVMCIRuntime can be garbled
  • b92abac: 8263433: Shenandoah: Don't expect forwarded objects in set_concurrent_mark_in_progress()
  • 15dacca: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64
  • 7ed46bd: 8241716: Jpackage functionality to let users choose whether to create shortcuts
  • 3820ab9: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages
  • 273f8bd: 8263248: IGV: accept graphs without node categories
  • a9b4f03: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • 470b150: 8143041: Unify G1CollectorPolicy::PauseKind and G1YCType
  • f6b4ba0: 8261931: IGV: quick search fails on multi-line node labels

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2021
@robehn
Copy link
Contributor Author

robehn commented Mar 10, 2021

One typo below otherwise LGTM!

Thanks,
David

Thanks!

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

I thought I had submitted this yesterday. Sorry about that.

src/hotspot/share/runtime/handshake.cpp Show resolved Hide resolved
src/hotspot/share/runtime/handshake.cpp Show resolved Hide resolved
@robehn
Copy link
Contributor Author

robehn commented Mar 11, 2021

I thought I had submitted this yesterday. Sorry about that.

Thanks!

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up. Minor nit about the sort order of the imports in the new test remains.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

@robehn
Copy link
Contributor Author

robehn commented Mar 12, 2021

/integrate

@openjdk openjdk bot closed this Mar 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2021
@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@robehn Since your change was applied there have been 14 commits pushed to the master branch:

  • ff25939: 8263426: Reflow JfrNetworkUtilization::send_events
  • e25ad73: 8263430: Uninitialized Method* variables after JDK-8233913
  • 9f6b1d7: 8263436: Silly array comparison in GaloisCounterMode.overlapDetection
  • ad1f605: 8263353: assert(CompilerOracle::option_matches_type(option, value)) failed: Value must match option type
  • cf1c021: 8263480: ProblemList two jpackage tests on Windows
  • f3bd801: 8263403: [JVMCI] output written to tty via HotSpotJVMCIRuntime can be garbled
  • b92abac: 8263433: Shenandoah: Don't expect forwarded objects in set_concurrent_mark_in_progress()
  • 15dacca: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64
  • 7ed46bd: 8241716: Jpackage functionality to let users choose whether to create shortcuts
  • 3820ab9: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/7988c1d9aa7e3b990c17fdf5e31195e66e7fc5f2...master

Your commit was automatically rebased without conflicts.

Pushed as commit aa33443.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the 8262454-hs-timeout-st branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants