Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264028: Typo in javax.management.relation.RelationService::purgeRelations #2765

Closed
wants to merge 2 commits into from

Conversation

@horizonzy
Copy link
Contributor

@horizonzy horizonzy commented Feb 28, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264028: Typo in javax.management.relation.RelationService::purgeRelations

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2765/head:pull/2765
$ git checkout pull/2765

Update a local copy of the PR:
$ git checkout pull/2765
$ git pull https://git.openjdk.java.net/jdk pull/2765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2765

View PR using the GUI difftool:
$ git pr show -t 2765

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2765.diff

@bridgekeeper bridgekeeper bot added the oca label Feb 28, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 28, 2021

Hi @horizonzy, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user horizonzy" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 28, 2021

@horizonzy The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@horizonzy
Copy link
Contributor Author

@horizonzy horizonzy commented Feb 28, 2021

/signed

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 28, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

@robilad robilad commented Mar 3, 2021

Hi, please contact me at Dalibor.topic@oracle.com so that I can validate your OCA.

@shqking
Copy link
Contributor

@shqking shqking commented Mar 9, 2021

Hi. Just a reminder for you that the copyright year should be updated to 2021.

@horizonzy
Copy link
Contributor Author

@horizonzy horizonzy commented Mar 9, 2021

Hi. Just a reminder for you that the copyright year should be updated to 2021.

thanks

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@horizonzy Unknown command signed - for a list of valid commands use /help.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 23, 2021

Hi, I have submitted the bug for it: https://bugs.openjdk.java.net/browse/JDK-8264028 -- please change the PR synopsis to "8264028: Typo in javax.management.relation.RelationService::purgeRelations" to get it properly hooked to PR metadata. After that, bots should tell what is next.

@horizonzy horizonzy changed the title Typo fix. 8264028: Typo in javax.management.relation.RelationService::purgeRelations Mar 23, 2021
@horizonzy
Copy link
Contributor Author

@horizonzy horizonzy commented Mar 23, 2021

Hi, I have submitted the bug for it: https://bugs.openjdk.java.net/browse/JDK-8264028 -- please change the PR synopsis to "8264028: Typo in javax.management.relation.RelationService::purgeRelations" to get it properly hooked to PR metadata. After that, bots should tell what is next.

ok, thanks.

@openjdk openjdk bot added the rfr label Mar 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2021

Webrevs

@shqking
Copy link
Contributor

@shqking shqking commented Mar 24, 2021

You may want to enable the GitHub Actions. Please go to https://github.com/horizonzy/jdk/actions and then trigger the test workflow on your branch.

It would be fine if you do not run the test for this PR since only typo errors are fixed.
But I suggest enabling this and in this way all the necessary tests would be run automatically for your new PRs in the near future once they are submitted.

@horizonzy
Copy link
Contributor Author

@horizonzy horizonzy commented Mar 24, 2021

You may want to enable the GitHub Actions. Please go to https://github.com/horizonzy/jdk/actions and then trigger the test workflow on your branch.

It would be fine if you do not run the test for this PR since only typo errors are fixed.
But I suggest enabling this and in this way all the necessary tests would be run automatically for your new PRs in the near future once they are submitted.

thanks for your suggest.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Looks good.
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

⚠️ @horizonzy the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout typo-fix
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

@horizonzy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264028: Typo in javax.management.relation.RelationService::purgeRelations

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 832 new commits pushed to the master branch:

  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • bebfae4: 8264208: Console charset API
  • ... and 822 more: https://git.openjdk.java.net/jdk/compare/03d888f463c0a6e3fee70ed8ad606fc0a3082636...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 30, 2021
@horizonzy
Copy link
Contributor Author

@horizonzy horizonzy commented Apr 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@horizonzy
Your change (at version ce666cb) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 25, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@shipilev @horizonzy Since your change was applied there have been 832 commits pushed to the master branch:

  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • bebfae4: 8264208: Console charset API
  • ... and 822 more: https://git.openjdk.java.net/jdk/compare/03d888f463c0a6e3fee70ed8ad606fc0a3082636...master

Your commit was automatically rebased without conflicts.

Pushed as commit f1f2afd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants