Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210100: ParallelGC should use parallel WeakProcessor #2851

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 5, 2021

Benchmarking using specjvm2008 shows "Weak Processing" takes <1ms. There are >800 occurrences where "Weak Processing" takes >0.4ms, while only 5 occurrences after the patch, as shown in gc logs.

PS: I changed the log level from Debug to Info for "Weak Processing" for benchmarking in order not limit the logs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210100: ParallelGC should use parallel WeakProcessor

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2851/head:pull/2851
$ git checkout pull/2851

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 6, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8210100: ParallelGC should use parallel WeakProcessor

Reviewed-by: kbarrett, tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2021
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk openjdk bot closed this Mar 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2021
@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@albertnetymk Since your change was applied there have been 22 commits pushed to the master branch:

  • 679faa6: 8263097: Update JMH devkit to 1.28
  • ab2cfcc: 8252831: Correct "no comment" warnings in jdk.net module
  • 51cca57: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir
  • a0c3f24: 8263091: Remove CharacterData.isOtherUppercase/-Lowercase
  • 13625be: 8263090: Avoid reading volatile fields twice in Locale.getDefault(Category)
  • 61cff4d: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 22a3117: 8263137: Typos in sun.security.ssl.RenegoInfoExtension
  • 18fc350: 8259886: Improve SSL session cache performance and scalability
  • 3844ce4: 8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot
  • f2d0152: 8263043: Add test to verify order of tag output
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/9730266d02bc2952c3621ebc2b7d6dee2a97c0e0...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0da889e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the weak_roots branch March 8, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants