-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263358: Update java.lang to use instanceof pattern variable #2913
Conversation
👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into |
@pconcannon The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Mailing list message from Brian Goetz on hotspot-compiler-dev: These patches are obviously minimally correct.? However, for equals ??????????? if (!(o instanceof Key that)) return false; to ??? return (o instanceof Key that) The use of "if it's not, return false" is a holdover from when we On 3/10/2021 8:04 AM, Patrick Concannon wrote: |
src/java.base/share/classes/java/lang/module/ModuleDescriptor.java
Outdated
Show resolved
Hide resolved
Thanks for the suggestion, Brian. I've done this now and it can be viewed in commit e9d9131 |
@pconcannon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
src/java.base/share/classes/java/lang/constant/DynamicConstantDesc.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new changes look good to me.
/integrate |
@pconcannon Since your change was applied there have been 49 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 329697b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Could someone please review my code for updating the code in the
java.lang
package to make use of theinstanceof
pattern variable?Kind regards,
Patrick
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2913/head:pull/2913
$ git checkout pull/2913
To update a local copy of the PR:
$ git checkout pull/2913
$ git pull https://git.openjdk.java.net/jdk pull/2913/head