8214761: Bug in parallel Kahan summation implementation

[chrisdennis]

This pull request integrates the changes originally proposed by Ivan Gerasimov on the core-libs mailing list: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057239.html. I've simply taken his changes and applied them to HEAD. The commit is therefore attributed to him as Author and myself as Committer.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-8214761: Bug in parallel Kahan summation implementation

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2988/head:pull/2988
$ git checkout pull/2988

[bridgekeeper]

Hi @chrisdennis, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user chrisdennis" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@chrisdennis The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[chrisdennis]

/covered

I believe that I am covered by the OCA signed by Software AG. I have previously made contributions to the JDK prior to the Github adoption: 58faa32 ca4ee27 d1080de 27c2e51

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@chrisdennis Unknown command covered - for a list of valid commands use /help.

[igraves]

Having just looked over this on JBS and implemented similar fix before realizing you'd already done it - this looks good to me. I'll see if we can get the OCA stuff sorted so this can get unblocked.

[chrisdennis]

@igraves right now Oracle cannot find my employers OCA so it may be easier to simply close this PR and work on yours. I'll need to either get VP approval for a new OCA or get our legal department to track down a contract signed 8 years ago. Given that my PR is odd in that it's actually me trying to get an (ex?) Oracle engineers code integrated, moving ahead via your PR seems the better decision in every way.

[bridgekeeper]

@chrisdennis This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@chrisdennis This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.