Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out #3116

Closed
wants to merge 1 commit into from

Conversation

sisahoo
Copy link
Member

@sisahoo sisahoo commented Mar 22, 2021

The Test getting timeout intermittently because the SO_TIMEOUT of 5 seconds set on sslServerSocket. This time interval could be inadequate when the machine is too busy. Also it looks setting SO_TIMEOUT is unnecessary here. So the statement has been removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3116/head:pull/3116
$ git checkout pull/3116

To update a local copy of the PR:
$ git checkout pull/3116
$ git pull https://git.openjdk.java.net/jdk pull/3116/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2021

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out Mar 22, 2021
@openjdk openjdk bot added the rfr label Mar 22, 2021
@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@sisahoo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Mar 22, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out

Reviewed-by: xuelei, rhalade, hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • f84b52b: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • f08bf4b: 8263891: Changes for 8076985 missed the fix.
  • b2df513: 8261785: Calling "main" method in anonymous nested class crashes the JVM
  • 840ab7b: 8263894: Convert defaultPrinter and printers fields to local variables
  • ba504fc: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll
  • 0abbfb2: 8263729: [test] divert spurious output away from stream under test in ProcessBuilder Basic test
  • 6c2220e: 8263861: Shenandoah: Remove unused member in ShenandoahGCStateResetter
  • 5262d95: 8263855: Use the blessed modifier order in java.management/naming
  • 6f1bcb0: 8263593: Fix multiple typos in hsdis README
  • a9d2267: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 22, 2021
@sisahoo
Copy link
Member Author

sisahoo commented Mar 23, 2021

/integrate

@openjdk openjdk bot closed this Mar 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 23, 2021
@openjdk
Copy link

openjdk bot commented Mar 23, 2021

@sisahoo Since your change was applied there have been 16 commits pushed to the master branch:

  • 5a51d70: 8247895: SHA1PRNGReseed.java is calling setSeed(0)
  • b2a52ea: 8263342: Add --connect option to jhsdb hsdb/clhsdb
  • 6b4c654: 8263776: [JVMCI] add helper to perform Java upcalls
  • b23228d: 8263914: CDS fails to find the default shared archive on x86_32
  • a5e7a89: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32
  • f62b100: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices
  • f84b52b: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • f08bf4b: 8263891: Changes for 8076985 missed the fix.
  • b2df513: 8261785: Calling "main" method in anonymous nested class crashes the JVM
  • 840ab7b: 8263894: Convert defaultPrinter and printers fields to local variables
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/42104e5575a73c5c163f0b8c8b686543a5117f42...master

Your commit was automatically rebased without conflicts.

Pushed as commit 036ae0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sisahoo sisahoo deleted the JDK-8225438 branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
4 participants