Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262725: IGV: crash when removing all graphs in a group #3540

Closed
wants to merge 3 commits into from

Conversation

@robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Apr 16, 2021

This change makes IGV close graph views when their groups are either a) removed or b) emptied (all graphs are removed but the group remains), and avoids faulty graph view computation in case b).

Tested the following scenarios manually (on groups loaded both via network and from a file, and on JDK 8, 11, and 15):

  1. open a graph, then remove all graphs in the group (as described in the bug report);
  2. open a graph, then remove its group; and
  3. open a graph, then remove all graphs and groups (File -> Remove all graphs and groups).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262725: IGV: crash when removing all graphs in a group

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3540/head:pull/3540
$ git checkout pull/3540

Update a local copy of the PR:
$ git checkout pull/3540
$ git pull https://git.openjdk.java.net/jdk pull/3540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3540

View PR using the GUI difftool:
$ git pr show -t 3540

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3540.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@robcasloz The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 16, 2021

/label remove build

@openjdk openjdk bot removed the build label Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@robcasloz
The build label was successfully removed.

@robcasloz robcasloz marked this pull request as ready for review Apr 16, 2021
@openjdk openjdk bot added the rfr label Apr 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

@reinrich
Copy link
Contributor

@reinrich reinrich commented Apr 19, 2021

Hi Roberto,

thanks for providing the fix. I've built and tested it successfully as described in the bug report JDK-8262725. Your fix seems to solve this issue.

I'm still not able to remove the empty group virtual void java.lang.Object.<init>() as additional last step though.
Does this work for you?

Cheers, Richard.

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262725: IGV: crash when removing all graphs in a group

Make IGV close graph views when their groups are either removed or emptied, and
avoid faulty graph view computation for empty groups.

Reviewed-by: chagedorn, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • 79798c6: 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles
  • f1d4ae6: 8263718: unused-result warning happens at os_linux.cpp
  • 787908c: 8264221: Rewrite confusing stream API chain in SnippetMaps
  • 142edd3: 8265152: jpackage cleanup fails on Windows with IOException deleting msi
  • ab22407: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64
  • e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster
  • 713483c: 8265373: Change to GCC 10.3 for building on Linux at Oracle
  • 3990713: 8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
  • 5b43b39: 8263154: [macos] DMG builds have finder errors
  • 54cb388: 8252600: [JVMCI] remove mx configuration
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/10ec38f80b83a5a692212a121df096d4b6c99a16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 19, 2021
@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 19, 2021

Looks good!

Thanks for reviewing, Christian!

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 19, 2021

thanks for providing the fix. I've built and tested it successfully as described in the bug report JDK-8262725. Your fix seems to solve this issue.

Thanks for testing, Richard!

I'm still not able to remove the empty group virtual void java.lang.Object.<init>() as additional last step though.
Does this work for you?

The preceding fix 8262462 should make this possible, however I see now that it wasn't merged into this PR. I merged it now (04c0b3c), could you please try again?

@reinrich
Copy link
Contributor

@reinrich reinrich commented Apr 19, 2021

The preceding fix 8262462 should make this possible, however I see now that it wasn't merged into this PR. I merged it now (04c0b3c), could you please try again?

Working nicely now! 👍

Copy link
Contributor

@reinrich reinrich left a comment

I've tested the fix and found it solves the issues.
(Cannot really comment on the change itself as I'm not familiar with igv implementation / netbeans).

Thanks, Richard.

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 19, 2021

I've tested the fix and found it solves the issues.
(Cannot really comment on the change itself as I'm not familiar with igv implementation / netbeans).

Thanks, Richard.

Thanks for reviewing, Richard!

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 20, 2021

/summary
Make IGV close graph views when their groups are either removed or emptied, and
avoid faulty graph view computation for empty groups.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@robcasloz Setting summary to:

Make IGV close graph views when their groups are either removed or emptied, and
avoid faulty graph view computation for empty groups.

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Apr 20, 2021

/integrate

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@robcasloz Since your change was applied there have been 48 commits pushed to the master branch:

  • 79798c6: 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles
  • f1d4ae6: 8263718: unused-result warning happens at os_linux.cpp
  • 787908c: 8264221: Rewrite confusing stream API chain in SnippetMaps
  • 142edd3: 8265152: jpackage cleanup fails on Windows with IOException deleting msi
  • ab22407: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64
  • e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster
  • 713483c: 8265373: Change to GCC 10.3 for building on Linux at Oracle
  • 3990713: 8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
  • 5b43b39: 8263154: [macos] DMG builds have finder errors
  • 54cb388: 8252600: [JVMCI] remove mx configuration
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/10ec38f80b83a5a692212a121df096d4b6c99a16...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5136643.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants