-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265982: JDK-8264188 breaks build on macOS-aarch64 #3697
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, macos-aarch64 jobs in GHA are passing. Looks good!
@magicus Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b524a81. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Unfortunately JDK-8264188 broke the build on macosx-aarch64.
The likely culprit for this is that the newly introduced assembly file was named ".s" instead of ".S". However, I have still not verified that this (completely) fixes the issue, since my job got stuck in our CI system. Since this is a P1, I wanted to speed on the process by submitting this PR for review even though the results are not yet in. (I will not push until they are.)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3697/head:pull/3697
$ git checkout pull/3697
Update a local copy of the PR:
$ git checkout pull/3697
$ git pull https://git.openjdk.java.net/jdk pull/3697/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3697
View PR using the GUI difftool:
$ git pr show -t 3697
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3697.diff