Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266942: gtest/ os.iso8601_time_vm failed #4013


Copy link

@tstuefe tstuefe commented May 13, 2021

My test only worked on half the globe, since the timezone stamp comparison was wrong (always compared for '+').

Fixed that. Also made the UTC-variant-tests more strict by requiring the timezone delta to be 0000.

Tested manually with various time zones.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8266942: gtest/ os.iso8601_time_vm failed



Using git

Checkout this PR locally:
$ git fetch pull/4013/head:pull/4013
$ git checkout pull/4013

Update a local copy of the PR:
$ git checkout pull/4013
$ git pull pull/4013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4013

View PR using the GUI difftool:
$ git pr show -t 4013

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented May 13, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@tstuefe tstuefe force-pushed the JDK-8266942-gtest-os-iso8601_time_vm-failed branch from 9ef17de to 3565bee Compare May 13, 2021 15:41
@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2021
Copy link

openjdk bot commented May 13, 2021

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label May 13, 2021
Copy link

mlbridge bot commented May 13, 2021


Copy link


Copy link

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up.

Copy link

openjdk bot commented May 14, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8266942: gtest/ os.iso8601_time_vm failed

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 14, 2021
Copy link
Member Author

tstuefe commented May 15, 2021

@navyxliu , @dcubed-ojdk Thanks for reviewing!

Strictly speaking this does not yet fulfill the requirements of 2 reviewers, since @navyxliu is no committer yet, but I declare this patch retroactively trivial (should have done this right away).


@openjdk openjdk bot closed this May 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2021
Copy link

openjdk bot commented May 15, 2021

@tstuefe Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f3fb5a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link

I concur that this is a trivial fix.

@tstuefe tstuefe deleted the JDK-8266942-gtest-os-iso8601_time_vm-failed branch July 26, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-runtime integrated Pull request has been integrated
3 participants