JDK-8266942: gtest/GTestWrapper.java os.iso8601_time_vm failed

[tstuefe]

My test only worked on half the globe, since the timezone stamp comparison was wrong (always compared for '+').

Fixed that. Also made the UTC-variant-tests more strict by requiring the timezone delta to be 0000.

Tested manually with various time zones.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266942: gtest/GTestWrapper.java os.iso8601_time_vm failed

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4013/head:pull/4013
$ git checkout pull/4013

Update a local copy of the PR:
$ git checkout pull/4013
$ git pull https://git.openjdk.java.net/jdk pull/4013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4013

View PR using the GUI difftool:
$ git pr show -t 4013

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4013.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3565bee3)

[navyxliu]

LGTM.

[dcubed-ojdk]

Thumbs up.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266942: gtest/GTestWrapper.java os.iso8601_time_vm failed

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 7ab6dc8: 6676643: Improve current C_GetAttributeValue native implementation
• 28f1c7a: 8249395: (macos) jpackage tests timeout on MacPro5_1 systems
• be0a655: 8254598: StringDedupTable should use OopStorage
• 360928d: 8260046: Assert left >= right in pointer_delta() methods
• 5eda812: 8267180: Typo in copyright header for HashesTest
• e90388b: 8266461: tools/jmod/hashes/HashesTest.java fails: static @test methods
• 599d07c: 8263006: Add optimization for Max()Node and Min()Node
• 16ca370: 8265694: Investigate test StressHiddenClasses.java
• af4cd04: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem
• ebcf399: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/b4371e9bcaa1c8aa394b5eca409c5afc669cc146...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

@navyxliu , @dcubed-ojdk Thanks for reviewing!

Strictly speaking this does not yet fulfill the requirements of 2 reviewers, since @navyxliu is no committer yet, but I declare this patch retroactively trivial (should have done this right away).

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 21 commits pushed to the master branch:

• 7ab6dc8: 6676643: Improve current C_GetAttributeValue native implementation
• 28f1c7a: 8249395: (macos) jpackage tests timeout on MacPro5_1 systems
• be0a655: 8254598: StringDedupTable should use OopStorage
• 360928d: 8260046: Assert left >= right in pointer_delta() methods
• 5eda812: 8267180: Typo in copyright header for HashesTest
• e90388b: 8266461: tools/jmod/hashes/HashesTest.java fails: static @test methods
• 599d07c: 8263006: Add optimization for Max()Node and Min()Node
• 16ca370: 8265694: Investigate test StressHiddenClasses.java
• af4cd04: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem
• ebcf399: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/b4371e9bcaa1c8aa394b5eca409c5afc669cc146...master

Your commit was automatically rebased without conflicts.

Pushed as commit f3fb5a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dcubed-ojdk]

I concur that this is a trivial fix.