8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager #4071
Please review the test changes for JEP 411.
With JEP 411 and the default value of
To make it easier to focus your review on the tests in your area, this PR is divided into multiple commits for different areas (
Due to the size of this PR, no attempt is made to update copyright years for all files to minimize unnecessary merge conflict.
Please note that this PR can be integrated before the source changes for JEP 411, as the possible values of this system property was already defined long time ago in JDK 9.
Most of the change in this PR is a simple adding of
There are several tests that launch another Java process that needs to call the
3 langtools tests are added into problem list due to JDK-8265611.
2 SQL tests are moved because they need different options on the
The source change for JEP 411 is at #4073.
The text was updated successfully, but these errors were encountered:
@wangweij The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
@wangweij This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the
The changes look okay but a bit inconsistent on where -Djava...=allow is inserted for tests that already set other system properties or other parameters. Not a correctness issue, just looks odd in several places, e.g.
test/jdk/java/lang/System/LoggerFinder/BaseLoggerFinderTest/BaseLoggerFinderTest.java - the tests sets the system properties after -Xbootclasspath/a: but the change means it sets properties before and after.
test/jdk/java/lang/Class/getResource/ResourcesTest.java - you've added it in the middle of the module and class path parameters.
For uses using ProcessTools then it seems to be very random.
I've updated the 3 cases you mentioned in my local repo and will go through more. Yes it looks good to group system property settings together. Thanks.
@wangweij Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 640a2af.