-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267969: Add vectorized implementation for VectorMask.eq() #4272
Conversation
👋 Welcome back xgong! A progress list of the required criteria for merging this PR into |
/label hotspot-compiler |
@XiaohongGong To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label core-libs |
@XiaohongGong |
/label hotspot-compiler |
@XiaohongGong |
@XiaohongGong The |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks. Later we may want to consider pushing this down as an intrinsic, perhaps reusing VectorSupport.compare
.
@XiaohongGong This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@PaulSandoz, @neliasso) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks for your review @PaulSandoz ! Yes, reusing |
/integrate |
@XiaohongGong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please wait until you have two reviewers before integrating. |
/sponsor |
@neliasso @XiaohongGong Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 496fb90. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Sure! Thanks so much for looking at this PR! |
Currently
"VectorMask.eq()"
is not vectorized:This can be implemented by calling
"xor(m.not())"
directly.The performance improved about 1.4x ~ 1.9x for the following benchmark with different basic types:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4272/head:pull/4272
$ git checkout pull/4272
Update a local copy of the PR:
$ git checkout pull/4272
$ git pull https://git.openjdk.java.net/jdk pull/4272/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4272
View PR using the GUI difftool:
$ git pr show -t 4272
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4272.diff