Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268103: JNI functions incorrectly return a double after JDK-8265836 #4300

Closed
wants to merge 1 commit into from

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 2, 2021

Please review this trivial patch. Stubs should return -1 for jlong rather than -1.0 (double) on aix/macosx.

Thoughts?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268103: JNI functions incorrectly return a double after JDK-8265836

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4300/head:pull/4300
$ git checkout pull/4300

Update a local copy of the PR:
$ git checkout pull/4300
$ git pull https://git.openjdk.java.net/jdk pull/4300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4300

View PR using the GUI difftool:
$ git pr show -t 4300

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4300.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jerboaa The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2021

Webrevs

@tanghaoth90
Copy link
Contributor

@tanghaoth90 tanghaoth90 commented Jun 2, 2021

LGTM. Thanks!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and trivial.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268103: JNI functions incorrectly return a double after JDK-8265836

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 71425dd: 8267118: OutOfMemoryError cannot be caught as a Throwable
  • de6472c: 8267459: Pasting Unicode characters into JShell does not work.
  • 9247630: 8265270: Type.getEnclosingType() may fail with CompletionFailure
  • 2d494bf: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries
  • bba3728: 8267726: ZGC: array_copy_requires_gc_barriers too strict

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jun 2, 2021

Thanks for the reviews!

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jerboaa Since your change was applied there have been 8 commits pushed to the master branch:

  • 6765f90: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
  • 19450b9: 8266281: Assign Symbols to the package selector expression
  • a223189: 8264774: Implementation of Foreign Function and Memory API (Incubator)
  • 71425dd: 8267118: OutOfMemoryError cannot be caught as a Throwable
  • de6472c: 8267459: Pasting Unicode characters into JShell does not work.
  • 9247630: 8265270: Type.getEnclosingType() may fail with CompletionFailure
  • 2d494bf: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries
  • bba3728: 8267726: ZGC: array_copy_requires_gc_barriers too strict

Your commit was automatically rebased without conflicts.

Pushed as commit 2963c9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants