-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268122: Add specific gc cause for G1 full collections #4357
Conversation
👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into |
Webrevs
|
Also removing Allocation Failure cause which should not be used by G1 collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Pre-existing: The two changed tests seem to be exactly the same....
The "G1ConcurrentMark" test is run with I just pushed a small change to move the new cause up to under the "G1 Evacuation Pause" in the enum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8268163-full-gc-order
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@kstefanj this pull request can not be integrated into git checkout 8268122-gc-cause
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@kstefanj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks @tschatzl and @kimbarrett for the reviews. /integrate |
@kstefanj Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit caf7f49. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change to add a new GC cause for GC Full collections that are caused by a prior collection not being able to free up enough space.
Summary
During the review of PR #3143 it got pretty clear that reusing the Young GC cause for a following Full GC is not always good. A solution for this is to add a new GC cause that is used if a young collection can't free up enough space. This cause will not be used for other explicit Full GCs, like a call to
System.gc()
.The would result in a change from:
to:
This PR is currently based in PR #4342, where we slightly change how Full GCs are scheduled if a Younc GC can't free up enough space.
Testing
I've tested this change together with PR #4342 and tier1-3 looks good. Also done manual testing making sure the GC-cause is used correctly.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4357/head:pull/4357
$ git checkout pull/4357
Update a local copy of the PR:
$ git checkout pull/4357
$ git pull https://git.openjdk.java.net/jdk pull/4357/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4357
View PR using the GUI difftool:
$ git pr show -t 4357
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4357.diff