Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268647: Generation::expand_and_allocate has unused "parallel" argument #4485

Closed
wants to merge 2 commits into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jun 14, 2021

Please review this simplification of the Generation class and the classes
derived from it. There are no callers of expand_and_allocate that pass the
third argument explicitly, so its value is always the default (false) value.

This change removes the argument and updates the two implementations of this
virtual function accordingly.

[The "parallel" argument is probably a leftover from CMS support.]

Testing:
mach5 tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268647: Generation::expand_and_allocate has unused "parallel" argument

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4485/head:pull/4485
$ git checkout pull/4485

Update a local copy of the PR:
$ git checkout pull/4485
$ git pull https://git.openjdk.java.net/jdk pull/4485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4485

View PR using the GUI difftool:
$ git pr show -t 4485

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4485.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 14, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jun 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 14, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm. I suggested a small whitespace change.

Loading

HeapWord* DefNewGeneration::expand_and_allocate(size_t size,
bool is_tlab,
bool parallel) {
HeapWord* DefNewGeneration::expand_and_allocate(size_t size, bool is_tlab) {
Copy link
Contributor

@tschatzl tschatzl Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HeapWord* DefNewGeneration::expand_and_allocate(size_t size, bool is_tlab) {
HeapWord* DefNewGeneration::expand_and_allocate(size_t size, bool is_tlab) {

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268647: Generation::expand_and_allocate has unused "parallel" argument

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 0b09129: 8268620: InfiniteLoopException test may fail on x86 platforms
  • d384093: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 9f3c7e7: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 2e70bc3: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • e59acd9: 8268699: Shenandoah: Add test for JDK-8268127
  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/c0b4407d09a7bf9f15553dc5344b1e354b150d57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 14, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jun 15, 2021

Thanks @albertnetymk and @tschatzl for reviews.

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jun 15, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit 00e33a4.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 0b09129: 8268620: InfiniteLoopException test may fail on x86 platforms
  • d384093: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 9f3c7e7: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 2e70bc3: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • e59acd9: 8268699: Shenandoah: Add test for JDK-8268127
  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/c0b4407d09a7bf9f15553dc5344b1e354b150d57...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@kimbarrett Pushed as commit 00e33a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kimbarrett kimbarrett deleted the remove_parallel branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants