Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267752: KVHashtable doesn't deallocate entries #4501

Closed
wants to merge 1 commit into from

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Jun 15, 2021

Add a free_entry iteration to the destructor of ~KVHashtables.
Tested with tier1-3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4501/head:pull/4501
$ git checkout pull/4501

Update a local copy of the PR:
$ git checkout pull/4501
$ git pull https://git.openjdk.java.net/jdk pull/4501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4501

View PR using the GUI difftool:
$ git pr show -t 4501

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4501.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Jun 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Webrevs

Loading

src/hotspot/share/utilities/hashtable.hpp Show resolved Hide resolved
Loading
iklam
iklam approved these changes Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267752: KVHashtable doesn't deallocate entries

Reviewed-by: iklam, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 16, 2021
Copy link
Member

@tstuefe tstuefe left a comment

Hi Coleen,

seems to be right.

I did a little test (filling a KV<int, int> hashtable with 500mio entries and releasing it) and was confused when RSS did not go down es expected; but this seems to be a glibc issue (repeating the test did not allocate twice as much memory, so the second round of mallocs reused the first frees).

(Update: this is entirely an glibc issue of not releasing memory to the OS)

See my question inline about unlink(). Otherwise this is fine. This was only ever used in CDS dumping, right?

Cheers, Thomas

Loading

src/hotspot/share/utilities/hashtable.hpp Show resolved Hide resolved
Loading
@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Jun 16, 2021

Thanks Ioi and Thomas for the code reviews.
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

Going to push as commit 72b3b0a.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@coleenp Pushed as commit 72b3b0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@coleenp coleenp deleted the hashtable branch Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants