-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271163: G1 uses wrong degree of MT processing since JDK-8270169 #4888
8271163: G1 uses wrong degree of MT processing since JDK-8270169 #4888
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
30c92b0
to
c7628e6
Compare
Webrevs
|
c7628e6
to
04e043a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
As this is a simple backout (plus commentary), I suggest not waiting the usual 24 hours before pushing, to reduce testing noise. |
Since this is basically a clean backout of JDK-8270169, I'll skip the 24h rule requirement. Thanks @kimbarrett @albertnetymk for your reviews. /integrate |
Going to push as commit 8c8e3a0.
Your commit was automatically rebased without conflicts. |
Hi all,
JDK-8270169 changed the amount of resources supplied by the CM reference processor, assuming that the CM ref processor is only ever used with the marking threads.
This is unfortunately not true, the CM reference processor is also used by the Remark pause for discovery using the parallel gc worker threads.
This causes crashes because of the code assuming single threaded operation while it is not.
The solution proposed here is to just revert JDK-8270169 which introduced that change. Applies cleanly.
I also added a comment in the reference processor constructor to why we need to consider both thread counts.
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4888/head:pull/4888
$ git checkout pull/4888
Update a local copy of the PR:
$ git checkout pull/4888
$ git pull https://git.openjdk.java.net/jdk pull/4888/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4888
View PR using the GUI difftool:
$ git pr show -t 4888
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4888.diff