Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #500

Closed
wants to merge 1 commit into from
Closed

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows #500

wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 5, 2020 •
edited by openjdk bot
Loading

This test was seen to be failing in mach5 hidpi system on windows.
The test actually checks for the fact that popup size should be 10 pixels wider than the comboBox width and the popup should overlap the comboBox by 5 pixels (negative y-offset) which maynot exactly be same in hidpi mode.
Fix is to make it run for scale 1 as the fix is not dependant on hidpi mode.
Also, some cleanup is done like changing setAutoDelay() which is normally set to 100ms for several other tests to make it consistent.
Also, mach5 run for several iterations is green and link is posted in JBS.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/500/head:pull/500
$ git checkout pull/500

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2020
@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Oct 5, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2020

Webrevs

azuev-java
azuev-java approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 5, 2020 •
edited
Loading

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows

Reviewed-by: kizune, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 129 new commits pushed to the master branch:

  • 81dae70: 8253948: Memory leak in ImageFileReader
  • 65cab55: 8253971: ZGC: Flush mark stacks after processing concurrent roots
  • 19219a9: 8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()
  • 5d4a135: 8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.
  • 289ae79: 8252998: ModuleWrapper.gmk doesn't consult include path
  • 9604ee8: 8248238: Implementation: JEP 388: Windows AArch64 Support
  • 1c2754b: 8253269: The CheckCommonColors test should provide more info on failure
  • d296708: 8253606: Need to add missed constructor to the SwingEventMonitor
  • 5810238: 8253945: Missed default constructor for StreamPrintServiceFactory.java
  • 123e786: 8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test
  • ... and 119 more: https://git.openjdk.java.net/jdk/compare/dcde95ba0d68a3aa3f2f405c6141d645a52c28e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2020
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Oct 7, 2020

/integrate

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2020
@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@prsadhuk Since your change was applied there have been 155 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit bdd5782.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the test-failure-fix branch October 7, 2020 06:49
mrserb
mrserb reviewed Oct 7, 2020
View reviewed changes
test/jdk/javax/swing/plaf/synth/7158712/bug7158712.java

SynthLookAndFeel laf = new SynthLookAndFeel();

laf.load(new ByteArrayInputStream(SYNTH_XML.getBytes("UTF8")), bug7158712.class);

UIManager.setLookAndFeel(laf);

EventQueue.invokeAndWait(new Runnable() {
SwingUtilities.invokeAndWait(new Runnable() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the EventQueue is the right thing to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrserb mrserb mrserb left review comments

@prrace prrace prrace approved these changes

@azuev-java azuev-java azuev-java approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prsadhuk @mrserb @prrace @azuev-java