Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags #5000

Closed
wants to merge 1 commit into from
Closed

8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@
* @test TestAbortOnVMOperationTimeout
* @bug 8181143 8269523
* @summary Check abort on VM timeout is working
* @requires vm.flagless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's essentially the driver tests - ie tests that call process builder to run the test that need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two kind of tests that can/should have vm.flagless:

  • 1st, the driver tests that don't pass external flags to a child JVM, in that case, it's useless to run the test w/ any external flags as you won't get any signal and just waste time
  • 2nd, tests that aren't designed to be run w/ external flags, tests that highly depend on JVM configuration to the extent that the majority of configurations make such tests inapplicable, e.g. jfr tests.

all the tests which I'm marking in 8246498 sub-tasks are of the first kind.

* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.management
Expand Down
1 change: 1 addition & 0 deletions test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@
* @test TestAbortVMOnSafepointTimeout
* @summary Check if VM can kill thread which doesn't reach safepoint.
* @bug 8219584 8227528
* @requires vm.flagless
* @library /testlibrary /test/lib
* @build sun.hotspot.WhiteBox
* @run driver jdk.test.lib.helpers.ClassFileInstaller sun.hotspot.WhiteBox
Expand Down