8262751: RenderPipelineState assertion error in J2DDemo #5227

avu · 2021-08-23T19:30:35Z

Provide correct pipeline state for MTLPaint after reset

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8262751: RenderPipelineState assertion error in J2DDemo

Reviewers

Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5227/head:pull/5227
$ git checkout pull/5227

Update a local copy of the PR:
$ git checkout pull/5227
$ git pull https://git.openjdk.java.net/jdk pull/5227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5227

View PR using the GUI difftool:
$ git pr show -t 5227

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5227.diff

Provide correct pipeline state for MTLPaint after reset

bridgekeeper · 2021-08-23T19:32:04Z

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-08-23T19:34:26Z

@avu The following label will be automatically applied to this pull request:

2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-08-23T19:39:45Z

Webrevs

01: Full - Incremental (2967ffb0)
00: Full (ce919029)

jayathirthrao · 2021-08-25T05:41:03Z

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m

@@ -948,6 +967,16 @@ - (void)setPipelineState:(id <MTLRenderCommandEncoder>)encoder
                                                                             renderOptions:renderOptions
                                                                             stencilNeeded:[mtlc.clip isShape]];
        [encoder setRenderPipelineState:pipelineState];
+    } else {
+      // Fallback to valid pipeline state


We should not call it a valid pipeline state. It is more of standard pipeline state with color 0 which we are using after reset.

We are hitting default MTLPaint without any texture(which seems to be the main root cause for this issue- state management problem) and we end up not setting any pipeline state. Please reword this comment.

Also is it possible for us to just return at any earlier stage before we hit setRenderPipelineState() without valid texture or color?

Yes, I agree it's not valid but standard or default state.

Also is it possible for us to just return at any earlier stage before we hit setRenderPipelineState() without valid texture or color?

The problem is that I'm unable to reproduce this failure. So, it's difficult to provide a robust empirical solution.

jayathirthrao · 2021-08-25T06:13:17Z

I have given all test run on metal pipeline. I will add my observation once it is done.

Minor correction in the comments

jayathirthrao

All test run is fine. Change looks good to me.

openjdk · 2021-08-26T05:05:28Z

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262751: RenderPipelineState assertion error in J2DDemo

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
2ef6871: 8272447: Remove 'native' ranked Mutex
63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
1e3e333: 8272884: Make VoidClosure::do_void pure virtual
0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
b17b821: 8272639: jpackaged applications using microphone on mac
... and 19 more: https://git.openjdk.java.net/jdk/compare/18840724749c839259688bfa052652a1f34a378a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

avu · 2021-08-26T07:27:25Z

/integrate

openjdk · 2021-08-26T07:28:32Z

Going to push as commit 49b2789.
Since your change was applied there have been 30 commits pushed to the master branch:

a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
2ef6871: 8272447: Remove 'native' ranked Mutex
63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
1e3e333: 8272884: Make VoidClosure::do_void pure virtual
0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
... and 20 more: https://git.openjdk.java.net/jdk/compare/18840724749c839259688bfa052652a1f34a378a...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-08-26T07:28:44Z

@avu Pushed as commit 49b2789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8262751: RenderPipelineState assertion error in J2DDemo

ce91902

Provide correct pipeline state for MTLPaint after reset

openjdk bot added the rfr Pull request is ready for review label Aug 23, 2021

openjdk bot added the 2d client-libs-dev@openjdk.org label Aug 23, 2021

jayathirthrao reviewed Aug 25, 2021

View reviewed changes

8262751: RenderPipelineState assertion error in J2DDemo

2967ffb

Minor correction in the comments

jayathirthrao approved these changes Aug 26, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2021

openjdk bot closed this Aug 26, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Aug 26, 2021

openjdk bot removed the rfr Pull request is ready for review label Aug 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8262751: RenderPipelineState assertion error in J2DDemo #5227

8262751: RenderPipelineState assertion error in J2DDemo #5227

avu commented Aug 23, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 23, 2021

openjdk bot commented Aug 23, 2021

mlbridge bot commented Aug 23, 2021 •

edited

Loading

jayathirthrao Aug 25, 2021 •

edited

Loading

jayathirthrao Aug 25, 2021

avu Aug 25, 2021

jayathirthrao commented Aug 25, 2021

jayathirthrao left a comment

openjdk bot commented Aug 26, 2021

avu commented Aug 26, 2021

openjdk bot commented Aug 26, 2021

openjdk bot commented Aug 26, 2021

8262751: RenderPipelineState assertion error in J2DDemo #5227

8262751: RenderPipelineState assertion error in J2DDemo #5227

Conversation

avu commented Aug 23, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Aug 23, 2021

openjdk bot commented Aug 23, 2021

mlbridge bot commented Aug 23, 2021 • edited Loading

Webrevs

jayathirthrao Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

jayathirthrao Aug 25, 2021

Choose a reason for hiding this comment

avu Aug 25, 2021

Choose a reason for hiding this comment

jayathirthrao commented Aug 25, 2021

jayathirthrao left a comment

Choose a reason for hiding this comment

openjdk bot commented Aug 26, 2021

avu commented Aug 26, 2021

openjdk bot commented Aug 26, 2021

openjdk bot commented Aug 26, 2021

avu commented Aug 23, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 23, 2021 •

edited

Loading

jayathirthrao Aug 25, 2021 •

edited

Loading