Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262751: RenderPipelineState assertion error in J2DDemo #5227

Closed
wants to merge 2 commits into from

Conversation

@avu
Copy link

@avu avu commented Aug 23, 2021

Provide correct pipeline state for MTLPaint after reset


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262751: RenderPipelineState assertion error in J2DDemo

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5227/head:pull/5227
$ git checkout pull/5227

Update a local copy of the PR:
$ git checkout pull/5227
$ git pull https://git.openjdk.java.net/jdk pull/5227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5227

View PR using the GUI difftool:
$ git pr show -t 5227

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5227.diff

Provide correct pipeline state for MTLPaint after reset
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@avu The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Aug 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 23, 2021

Webrevs

@@ -948,6 +967,16 @@ - (void)setPipelineState:(id <MTLRenderCommandEncoder>)encoder
renderOptions:renderOptions
stencilNeeded:[mtlc.clip isShape]];
[encoder setRenderPipelineState:pipelineState];
} else {
// Fallback to valid pipeline state
Copy link
Member

@jayathirthrao jayathirthrao Aug 25, 2021

We should not call it a valid pipeline state. It is more of standard pipeline state with color 0 which we are using after reset.

We are hitting default MTLPaint without any texture(which seems to be the main root cause for this issue- state management problem) and we end up not setting any pipeline state. Please reword this comment.

Copy link
Member

@jayathirthrao jayathirthrao Aug 25, 2021

Also is it possible for us to just return at any earlier stage before we hit setRenderPipelineState() without valid texture or color?

Copy link
Author

@avu avu Aug 25, 2021

Yes, I agree it's not valid but standard or default state.

Also is it possible for us to just return at any earlier stage before we hit setRenderPipelineState() without valid texture or color?

The problem is that I'm unable to reproduce this failure. So, it's difficult to provide a robust empirical solution.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Aug 25, 2021

I have given all test run on metal pipeline. I will add my observation once it is done.

Copy link
Member

@jayathirthrao jayathirthrao left a comment

All test run is fine. Change looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262751: RenderPipelineState assertion error in J2DDemo

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
  • c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
  • 1e3e333: 8272884: Make VoidClosure::do_void pure virtual
  • 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
  • b17b821: 8272639: jpackaged applications using microphone on mac
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/18840724749c839259688bfa052652a1f34a378a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2021
@avu
Copy link
Author

@avu avu commented Aug 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

Going to push as commit 49b2789.
Since your change was applied there have been 30 commits pushed to the master branch:

  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
  • c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
  • 1e3e333: 8272884: Make VoidClosure::do_void pure virtual
  • 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/18840724749c839259688bfa052652a1f34a378a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated and removed ready labels Aug 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@avu Pushed as commit 49b2789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants