-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8272866 java.util.random package summary contains incorrect mixing function in table #5279
Conversation
/csr |
👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into |
@JimLaskey the issue for this pull request, JDK-8272866, already has an approved CSR request: JDK-8272988 |
@JimLaskey The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@JimLaskey This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e66c8af.
Your commit was automatically rebased without conflicts. |
@JimLaskey Pushed as commit e66c8af. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The table 'LXM Multipliers' at the end of the javadoc for the java.util.random package states that the mixing function is mixLea32 for all the 64/128-bit LCG based generators. This should be updated to mixLea64 for the 64/128-bit LCG generators. Only the L32X64MixRandom which uses a 32-bit LCG will use the mixLea32 mixing function.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5279/head:pull/5279
$ git checkout pull/5279
Update a local copy of the PR:
$ git checkout pull/5279
$ git pull https://git.openjdk.java.net/jdk pull/5279/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5279
View PR using the GUI difftool:
$ git pr show -t 5279
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5279.diff