Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272866 java.util.random package summary contains incorrect mixing function in table #5279

Closed
wants to merge 1 commit into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Aug 27, 2021

The table 'LXM Multipliers' at the end of the javadoc for the java.util.random package states that the mixing function is mixLea32 for all the 64/128-bit LCG based generators. This should be updated to mixLea64 for the 64/128-bit LCG generators. Only the L32X64MixRandom which uses a 32-bit LCG will use the mixLea32 mixing function.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272866: java.util.random package summary contains incorrect mixing function in table

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5279/head:pull/5279
$ git checkout pull/5279

Update a local copy of the PR:
$ git checkout pull/5279
$ git pull https://git.openjdk.java.net/jdk pull/5279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5279

View PR using the GUI difftool:
$ git pr show -t 5279

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5279.diff

@JimLaskey
Copy link
Member Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 27, 2021
@openjdk
Copy link

openjdk bot commented Aug 27, 2021

@JimLaskey the issue for this pull request, JDK-8272866, already has an approved CSR request: JDK-8272988

@openjdk
Copy link

openjdk bot commented Aug 27, 2021

@JimLaskey The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 27, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 27, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272866: java.util.random package summary contains incorrect mixing function in table

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • a033aa5: 8273072: Avoid using += in configure
  • b92214a: 8272480: Remove Mutex::access rank
  • 596b075: 8258465: Headless build fails due to missing X11 headers on linux
  • a49a0c5: 8273062: Generation::refs_discovery_is_xxx functions are unused
  • ebd62bc: 8272846: Move some runtime/Metaspace/elastic/ tests out of tier1
  • 46684a4: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
  • c925c7f: 8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array
  • 76baace: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
  • b16a04e: 8271186: Add UL option to replace newline char
  • d732c30: 8272863: Replace usages of Collections.sort with List.sort call in public java modules
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/2ef6871118109b294e3148c8f15d4335039dd121...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 27, 2021
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 27, 2021

Going to push as commit e66c8af.
Since your change was applied there have been 25 commits pushed to the master branch:

  • d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • a033aa5: 8273072: Avoid using += in configure
  • b92214a: 8272480: Remove Mutex::access rank
  • 596b075: 8258465: Headless build fails due to missing X11 headers on linux
  • a49a0c5: 8273062: Generation::refs_discovery_is_xxx functions are unused
  • ebd62bc: 8272846: Move some runtime/Metaspace/elastic/ tests out of tier1
  • 46684a4: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
  • c925c7f: 8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array
  • 76baace: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/2ef6871118109b294e3148c8f15d4335039dd121...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 27, 2021
@openjdk
Copy link

openjdk bot commented Aug 27, 2021

@JimLaskey Pushed as commit e66c8af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants